Repository navigation
Explorer: draw it with the Vortex design system, and build it with Bun - #11193
Conversation
Replace package-lock.json with bun.lock, migrated at the same versions. bunfig.toml sets the isolated linker and a 7-day minimum release age. An empty trustedDependencies list stops Bun's default allowlist from running lifecycle scripts; the only one in the tree is esbuild's optional postinstall. Signed-off-by: Will Manning <will@willmanning.io>
biome.jsonc keeps the Prettier style (single quotes, trailing commas, and 100 columns), turns on the recommended rules, and adds the React hook rules. The Storybook ESLint plugin has no Biome equivalent and goes away. Formatting now also covers vite.config.ts and the JSON configs. Signed-off-by: Will Manning <will@willmanning.io>
Give buttons an explicit type, hide decorative SVG icons from screen readers, and label the treemap. Replace two loops that only ran once with plain conditions. Apply Biome's fixes for type-only imports, template strings, and an optional chain. Signed-off-by: Will Manning <will@willmanning.io>
TypeScript 7 is the native compiler. It supports project references, so tsc -b stays. Signed-off-by: Will Manning <will@willmanning.io>
…yTypes The code needed 22 small fixes, all for indexed access: narrow where it reads naturally, and assert where an index is in range by construction. Signed-off-by: Will Manning <will@willmanning.io>
Raise the ranges to the versions in use and refresh the lock file: Storybook 10.6.5, React 19.3.1, Vite 8.3.5, and the rest. Newer @vitejs/plugin-react, Tailwind CSS, and react-virtual releases are younger than 7 days, so Bun keeps the previous ones. Signed-off-by: Will Manning <will@willmanning.io>
useTable replaces useReactTable. The table registers the sorting and column sizing features it uses, and the sort functions that 'auto' sorting can pick. Rows render their cells with getAllCells, because the table does not hide columns. Signed-off-by: Will Manning <will@willmanning.io>
REUSE.toml covers *.json but not *.jsonc. Signed-off-by: Will Manning <will@willmanning.io>
setup-bun installs Bun 1.4.3, and bun install --frozen-lockfile replaces npm ci. setup-node stays, without the npm cache, because Storybook and Vite run on Node. Signed-off-by: Will Manning <will@willmanning.io>
vortex-web now takes its 7-day wait from bunfig.toml, because Renovate cannot pass it to Bun. Keep the npmrc workaround for npm's bundleDependencies bug: .github/vercel-cli still installs with npm. Signed-off-by: Will Manning <will@willmanning.io>
Signed-off-by: Will Manning <will@willmanning.io>
Signed-off-by: Will Manning <will@willmanning.io>
…of Tailwind Copy the system's tokens, base, and component styles into src/styles, and lay out the Explorer in explorer.css on top of them. Remove Tailwind. Set the theme before the first paint from public/theme.js, because the CSP allows no inline script. Load Geist and Geist Mono only. Signed-off-by: Will Manning <will@willmanning.io>
…pen screen The header carries the wordmark, the links to the other Vortex sites, the view switch, and the theme switch. The preview's splitter takes the keyboard. Signed-off-by: Will Manning <will@willmanning.io>
The tree uses the system's LayoutTree, with the keys of the WAI-ARIA tree pattern. The tabs use the tabs pattern. A dtype takes its colour from the system's vx-dt classes; an encoding is named, not coloured. Signed-off-by: Will Manning <will@willmanning.io>
The tables are the system's data table, with sorting heads that take the keyboard. The treemap and the swimlane read their colours from the tokens, so they follow the theme. Remove the swimlane parts and the file map that the app did not use. Signed-off-by: Will Manning <will@willmanning.io>
…nd README Every pointer control now has a keyboard path, so noStaticElementInteractions and useKeyWithClickEvents are errors. Storybook starts in the dark theme, as the app does, and offers System. Signed-off-by: Will Manning <will@willmanning.io>
…cted block's fill The treemap reads its colours from the tokens now, so its stories need not pin the dark theme. A selected block's size label takes the body ink, so it stays readable on the stronger fill. Signed-off-by: Will Manning <will@willmanning.io>
…p the file map's rules The system raises a popover with its edge, not a shadow. The file map left with its component. Signed-off-by: Will Manning <will@willmanning.io>
… in decimal units An error now says what did not happen and what to do, with the cause in a reference line. Bytes print in decimal units, as the system's Writing sets them and bench prints them. A short count drops a trailing .0. The theme is saved under the system's key, vx-theme, and a choice under the old key moves. Signed-off-by: Will Manning <will@willmanning.io>
… selection The data table's sticky head, row wash, and spacer rows, the compact field, and the tree's chevron now come from the system, so explorer.css drops its copies. The styles copy the new tables section in place of the whole blog section. In the treemap, only the selected block takes the accent ring, and a hovered block takes an ink stroke. Labels and sizes are 11px, sizes are ink-body, and a label that would be cut below eight characters is left out. The work area pads its bottom, so the tree pane and the preview end on one line. Signed-off-by: Will Manning <will@willmanning.io>
…to do when a pane does not load Copy the system's CSS again: the encoding chain's rules now come with the base section, a pressed chip's border is accent-ink, and focus rings draw inside a scrolling table. The encoding and buffer panes say what did not load and what to do, with the reason in a reference. The tree pane is named for its mode, and the detail pane and its tab list have their own names. Signed-off-by: Will Manning <will@willmanning.io>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 99ff569088
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
- The preview's height stops where the view keeps 120px, with the summary stacked below 1100px. - Below 640px the Menu holds the view switch's twin rows. - Keys over a group row in the tree focus it without selecting it, and a click on one opens it. - The treemap's frame takes the selection ring when the selected node is its root. - The swimlane's ticks fall on round steps, and the file's size ends the axis, set in from the edge. Signed-off-by: Will Manning <will@willmanning.io>
|
Before and after screenshots of the Storybook stories at 1440 px. In each image, the left side is Header with a file open, Light Detail pane, nothing selected, Dark |
The file map and the swimlane drew each dtype as a faint wash. Float was a burnt orange, and datetime in Dark was the status green. - The design system's dtype hues are now amber (float), lime (datetime), pink (bool), cyan (int), and violet (utf8), at one lightness in each theme. No hue is a status colour. - A file-map block fills solid in Dark and with a 40% tint and a hued edge in Light, through the system's --vx-dt-fill, --vx-dt-edge, and --vx-dt-ink. Every label reaches 4.5:1. - A swimlane segment is a thin mark, so it takes the full hue. - Re-sync the copies of the system's styles, which also brings the skip link, the syntax colours, and the display face up to date. Signed-off-by: Will Manning <will@willmanning.io>
|
Dtype colours, before (left) and after (right), in Dark and Light: the file map at the root and with many chunks, and the swimlane.
The screenshots come from the Storybook stories, because the WASM package was not built. 🤖 Generated with Claude Code |
- Remove three rules nothing uses (.x-sub, .x-ruler, .x-ruler-label) and eight that only restate the base reset. - On a phone the page gutter is the system's 16px. It was 24px. - Screen readers no longer read the breadcrumb separators. - The treemap's "Up to root" button shows its press again: its background is the surface, so the button's own press colour shows. - Load the same Geist weights as the design system. Signed-off-by: Will Manning <will@willmanning.io>
Takes the measure token and a corrected comment. Nothing the Explorer draws changes. Signed-off-by: Will Manning <will@willmanning.io>
The Header loads /vortex_wordmark.svg, which Storybook did not serve, so the shell's stories showed a broken image. Storybook now serves public/, as the app does. Signed-off-by: Will Manning <will@willmanning.io>
Signed-off-by: Will Manning <will@willmanning.io>















This PR draws the Explorer (vortex-web) with the Vortex design system and builds it with Bun.
explorer.cssfor the Explorer's own parts. Dtype colours come from the system. Encodings have no colour.vx-theme, and the old key moves over.Not run:
bun run wasm. Paired before and after screenshots will follow in a comment.🤖 Generated with Claude Code