Repository navigation
ci(bench): revalidate the benchmarks website once per develop push - #11192
Conversation
post-ingest.py sent POST /api/revalidate and a warm pass of about 26 requests after every benchmark job, so about 15 to 60 times an hour while develop benchmarks ran. commit-metadata.yml sent one more. Move the revalidate and the warm pass to scripts/refresh-bench-site.py. A new refresh-site job in develop-bench.yml runs it once, after the bench and sql jobs finish, with always() so that a failed benchmark does not stop the results of the other jobs from appearing. Ingestion stays in each job. The request shape is unchanged. Signed-off-by: Will Manning <will@willmanning.io>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 790d619d11
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
A workflow_dispatch run of commit-metadata.yml has no refresh-site job after it, so it revalidates the benchmarks website itself. Push runs still leave the revalidate to develop-bench.yml. Signed-off-by: Will Manning <will@willmanning.io>
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: b10818d3e3
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
…idate Move the refresh job into a reusable refresh-bench-site.yml workflow and call it once per run from develop-bench.yml, nightly-bench.yml and commit-metadata.yml. Nightly runs ingest production results too, and commit-metadata.yml does not wait for develop-bench.yml, so each refreshes after its own ingest. refresh-bench-site.py now tries the revalidate POST again after 5, 15 and 45 seconds on a transport error, HTTP 429 or HTTP 5xx. Signed-off-by: Will Manning <will@willmanning.io>
|
@codex review |
|
Codex Review: Didn't find any major issues. More of your lovely PRs please. Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
vortex-data/vortex#11192 moved the cache revalidate out of scripts/post-ingest.py into scripts/refresh-bench-site.py, which a reusable workflow runs once per CI run. Update the contract, the architecture docs, the secrets runbook, and two code comments to name the new caller and describe when it runs and how it handles failure. No behaviour changes. Signed-off-by: Will Manning <will@willmanning.io>
Before: each benchmark job sent
POST /api/revalidateand a warm pass of about 26 requests to bench.vortex.dev. During develop runs, this occurred about 15 to 60 times an hour.After: a reusable
refresh-bench-site.ymlworkflow sends one revalidate and one warm pass.develop-bench.ymlandnightly-bench.ymlcall it once per run, after all ingests, withalways().commit-metadata.ymlcalls it after its commit row. Thus a develop push gets two refreshes and a nightly run gets one. A failed revalidate is tried again three times. Ingestion stays in each job. The request shape agrees withbench/CONTRACT.md.Checks:
yamllint --strict, ruff and pytest pass. A local test server showed the correct requests.typoswas not installed. I read the workflow graph; no workflow run was started.🤖 Generated with Claude Code