Repository navigation
Push down list element casts and bool/int/uint casts to Float64 in DataFusion - #11161
Merged
Merged
Conversation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The DataFusion converter now pushes down integer and boolean casts to
Float64, plus list casts whose element cast is supported. These were left out of the cast allowlist from #9785, but Arrow and Vortex convert them the same way.array_sumneeds this: DataFusion always plans it asarray_sum(CAST(xs AS List<Float64>)).Changes
Booleanand every integer type →Float64: both engines useas f64(round to nearest, never fails; booleans become 1.0/0.0).UInt32 → Int64.List/LargeListcasts are classified by their element cast.FixedSizeList → Listand narrowing element nullability stay in DataFusion.