Repository navigation
Run all Windows CI checks in one job - #11077
Merged
Merged
Conversation
Python (windows-x64) and Rust tests (windows-x64) each started their own Windows instance. A Windows instance takes 85-105s to boot cold, and the windows-x64-pre pool keeps only one hot instance, so the second job usually waited for a cold boot. The new Windows (x64) job runs the Rust tests and then builds and smoke-tests the wheel on one instance. The Rust test RUSTFLAGS and linker now apply only to the test step, so the wheel build is the same as before. The wheel steps also run when a Rust test fails. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_018SWbErECNveeTkm1E4tBvp Signed-off-by: Robert Kruszewski <github@robertk.io>
Merging this PR will not alter performance1 warning
Comparing |
The first run of the merged Windows job passed all Rust tests, and then the wheel build failed with "There is not enough space on the disk". The wheel build cannot reuse target\ci, because it uses other RUSTFLAGS and target\x86_64-pc-windows-msvc, so delete target\ci first. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_018SWbErECNveeTkm1E4tBvp Signed-off-by: Robert Kruszewski <github@robertk.io>
joseph-isaacs
approved these changes
Nov 2, 2026
The PATH step now runs with runs-on and checkout. setup-prebuild and setup-python do not depend on each other, so they also run together. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Robert Kruszewski <github@robertk.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Merge
Python (windows-x64)andRust tests (windows-x64)into oneWindows (x64)job on one Windows instance.windows-x64-prepool keeps 1 hot instance during working hours, so the second Windows job of a push usually waited for a cold boot.RUSTFLAGS(crt-static,/Brepro) and therust-lldlinker now apply only to the test step. The wheel build uses the same settings as before and still mirrorspackage.yml.