Skip to content

Run all Windows CI checks in one job - #11077

Merged
robert3005 merged 3 commits into
developfrom
rk/ci-windows-single
Nov 2, 2026
Merged

robert3005 merged 3 commits into
developfrom
rk/ci-windows-single

Conversation

@robert3005

@robert3005 robert3005 commented Nov 1, 2026 •

Copy link
Copy Markdown
Contributor

Merge Python (windows-x64) and Rust tests (windows-x64) into one Windows (x64) job on one Windows instance.

  • A Windows instance takes 85–105s to boot cold, for our AMI and for the RunsOn base alike. The windows-x64-pre pool keeps 1 hot instance during working hours, so the second Windows job of a push usually waited for a cold boot.
  • The job runs the Rust tests first, then builds the wheel and imports it to round-trip a file. The wheel steps also run when a Rust test fails, so one run shows both results.
  • RUSTFLAGS (crt-static, /Brepro) and the rust-lld linker now apply only to the test step. The wheel build uses the same settings as before and still mirrors package.yml.

Python (windows-x64) and Rust tests (windows-x64) each started their own
Windows instance. A Windows instance takes 85-105s to boot cold, and the
windows-x64-pre pool keeps only one hot instance, so the second job
usually waited for a cold boot. The new Windows (x64) job runs the Rust
tests and then builds and smoke-tests the wheel on one instance.

The Rust test RUSTFLAGS and linker now apply only to the test step, so
the wheel build is the same as before. The wheel steps also run when a
Rust test fails.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_018SWbErECNveeTkm1E4tBvp
Signed-off-by: Robert Kruszewski <github@robertk.io>
@codspeed

codspeed Bot commented Nov 1, 2026 •

Copy link
Copy Markdown

Merging this PR will not alter performance

1 warning

⚠️ Walltime results may be unreliable

Some benchmarks used the Walltime instrument outside CodSpeed Macro Runners, which can make the results inconsistent.

Learn more about Macro Runners

See affected benchmarks

✅ 2318 untouched benchmarks


Comparing rk/ci-windows-single (4fb6b56) with develop (e3e7a4e)

Open in CodSpeed

The first run of the merged Windows job passed all Rust tests, and then
the wheel build failed with "There is not enough space on the disk". The
wheel build cannot reuse target\ci, because it uses other RUSTFLAGS and
target\x86_64-pc-windows-msvc, so delete target\ci first.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_018SWbErECNveeTkm1E4tBvp
Signed-off-by: Robert Kruszewski <github@robertk.io>
@robert3005 robert3005 added the changelog/skip Do not list PR in the changelog label Nov 2, 2026
Comment thread .github/workflows/ci.yml Resolved
The PATH step now runs with runs-on and checkout. setup-prebuild and
setup-python do not depend on each other, so they also run together.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Signed-off-by: Robert Kruszewski <github@robertk.io>
@robert3005
robert3005 enabled auto-merge (squash) November 2, 2026 11:19
@robert3005
robert3005 merged commit 4b1dcc3 into develop Nov 2, 2026
78 checks passed
@robert3005
robert3005 deleted the rk/ci-windows-single branch November 2, 2026 11:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog/skip Do not list PR in the changelog

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants