Repository navigation
Run the remaining benchmarks on the V2 scan - #11061
Merged
Merged
Conversation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follows #11055 (FineWeb). This moves every remaining benchmark except StatPopGen and PolarSignals onto the planner-driven V2 scan. After this PR, those two are the only benchmarks still on V1.
Changes
bench-orchestrator/bench_orchestrator/config.pysetsBENCHMARK_SCAN_V2toTrueforAPPIAN,CLICKBENCH_SORTED,GHARCHIVE,JOB,PUBLIC_BI,SPATIALBENCHandVORTEX_QUERIES.The
action/bench-sql-extendedlabel (pr-fullpreset) runs Appian, ClickBench sorted, JOB and the Vortex queries. No PR preset includes GH Archive, Public BI or SpatialBench, so this PR's benchmark runs don't measure those three.Checks
uv run --with pytest pytest tests/test_executor.pyinbench-orchestrator: 33 passed.uvx ruff check bench-orchestrator/bench_orchestrator/config.py: passes.Generated by Claude Code