Skip to content

Explain how to make python security fix within cooldown window - #11034

Merged
lwwmanning merged 4 commits into
developfrom
wm/renovate-js-lock-age
Nov 8, 2026
Merged

lwwmanning merged 4 commits into
developfrom
wm/renovate-js-lock-age

Conversation

@lwwmanning

@lwwmanning lwwmanning commented Oct 30, 2026 •

Copy link
Copy Markdown
Contributor

The JS lock file group sets minimumReleaseAge, so Renovate gives npm the 7-day wait as --before. But Renovate also checks that age against the lock refresh itself, and a lock refresh has no release date. Renovate's docs say npm does not enforce the age during lock maintenance. So renovate/stability-days stays pending, and Renovate never creates the branch.

This PR sets minimumReleaseAgeBehaviour: "timestamp-optional" on that group. The check then passes, and npm's --before still applies the wait. Codex found this in #10997 after it merged.

This PR also adds a section to CONTRIBUTING.md. uv's 7-day cutoff also blocks a Python security fix that was released in the last 7 days. The section shows the one-line bypass to add to the security PR.

🤖 Generated with Claude Code

The JS lock-file-maintenance group sets minimumReleaseAge so Renovate
passes the 7-day wait to npm as --before. But Renovate also checks that
age against the lock refresh itself, which has no release timestamp.
Renovate's docs mark npm as not enforcing the age during lock
maintenance, so with the default timestamp-required behaviour the
renovate/stability-days check stays pending and the branch is never
created.

Set minimumReleaseAgeBehaviour to timestamp-optional for that group:
the update without a timestamp passes the check, and npm's --before
still applies the wait. Found by Codex's review of #10997 after it
merged.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Signed-off-by: Will Manning <will@willmanning.io>
@lwwmanning lwwmanning added the changelog/chore A trivial change label Oct 30, 2026
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 30, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-08T00:00:55.051705Z cbf00da New commits
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

The root pyproject.toml makes uv skip releases younger than 7 days.
Renovate opens security updates at once, but uv still refuses a fix
that new, so the security PR fails to update uv.lock. Document the
one-line bypass, exclude-newer-package = { <package> = false }, and its
removal once the release ages out. Keeping the cutoff over dropping it
was a deliberate choice: without it, Python lock refreshes would take
releases as soon as they are published.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Signed-off-by: Will Manning <will@willmanning.io>
@lwwmanning
lwwmanning enabled auto-merge (squash) October 30, 2026 11:59
@robert3005 robert3005 changed the title chore: let the JS lock refresh pass Renovate's release-age check Explain how to make python security fix within cooldown window Oct 31, 2026
@robert3005

Copy link
Copy Markdown
Contributor

@lwwmanning you will need to rebase this to merge

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01RY8Dy1iff8nwQScNFY4LvK

Signed-off-by: Will Manning <will@willmanning.io>

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 8172f3cf60

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread CONTRIBUTING.md Resolved
Comment thread CONTRIBUTING.md Resolved
@codspeed

codspeed Bot commented Nov 7, 2026 •

Copy link
Copy Markdown

Merging this PR will improve performance by 11.22%

1 warning

⚠️ Walltime results may be unreliable

Some benchmarks used the Walltime instrument outside CodSpeed Macro Runners, which can make the results inconsistent.

Learn more about Macro Runners

See affected benchmarks

⚡ 22 improved benchmarks
✅ 1895 untouched benchmarks
⏩ 47 skipped benchmarks1

Performance Changes

Mode Benchmark BASE HEAD Efficiency
⚡ CPU Simulation encode_primitives[f32, (2000, 2)] 213.3 µs 185.6 µs +14.91%
⚡ Walltime dbp_assemble_kernel_avx2[(I128, 32768)] 18 µs 15.8 µs +14.13%
⚡ Walltime dbp_assemble_kernel_narrow_msp_avx2[(I256, 16384)] 19.4 µs 17.2 µs +12.72%
⚡ Walltime dbp_assemble_kernel_avx2[(I256, 16384)] 18.2 µs 16.2 µs +12.51%
⚡ Walltime random_rotating_avx2[(0.5, 0.02, "self_50pct_mask_2pct")] 50 µs 44.7 µs +11.87%
⚡ Walltime dbp_assemble_kernel_narrow_msp_avx2[(I128, 32768)] 20.7 µs 18.6 µs +11.56%
⚡ CPU Simulation take_filter_primitive_small_uncached_random_mask_random_indices[4096, 10] 29.7 µs 26.6 µs +11.31%
⚡ Walltime infallible_bool_avx2[i32, PerRowPerRow] 2.8 µs 2.5 µs +11.3%
⚡ Walltime threshold_avx512[64] 2.5 µs 2.2 µs +11.21%
⚡ Walltime dbp_assemble_kernel_avx512[(I128, 32768)] 18.3 µs 16.5 µs +10.95%
⚡ Walltime compare_float_avx512 4.4 µs 3.9 µs +10.8%
⚡ Walltime take_u32_from_1m_avx2[1048576] 642.4 µs 580.5 µs +10.65%
⚡ Walltime infallible_bool_avx512[i32, PerRowPerRow] 2.2 µs 2 µs +10.63%
⚡ Walltime dbp_split_kernel_mixed_null_avx512[(I256, 16384)] 31.3 µs 28.3 µs +10.6%
⚡ Walltime dbp_split_kernel_all_valid_avx512[(I256, 16384)] 28 µs 25.4 µs +10.41%
⚡ Walltime infallible_bool_avx512[i64, PerRowPerRow] 3.6 µs 3.2 µs +10.35%
⚡ Walltime compare_f32_avx512 2.8 µs 2.5 µs +10.35%
⚡ Walltime filter_avx512[64] 1.7 µs 1.5 µs +10.3%
⚡ Walltime bitpack_blocked_decompress_avx2[u64] 20.7 µs 18.8 µs +10.15%
⚡ Walltime dbp_assemble_kernel_narrow_msp_avx512[(I128, 32768)] 20.6 µs 18.7 µs +10.1%
... ... ... ... ... ...

ℹ️ Only the first 20 benchmarks are displayed. Go to the app to view all benchmarks.

Tip

Curious why performance improved? Comment @codspeedbot explain why performance improved on this PR, or directly use the CodSpeed MCP with your agent.


Comparing wm/renovate-js-lock-age (cbf00da) with develop (0a18845)

Open in CodSpeed

Footnotes

  1. 47 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

Plain uv lock keeps a locked version that still satisfies the
constraints, so the security fix needs --upgrade-package. Also say that
Cargo.lock refreshes do not wait 7 days.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01RY8Dy1iff8nwQScNFY4LvK
Signed-off-by: Will Manning <will@willmanning.io>
@lwwmanning
lwwmanning disabled auto-merge November 7, 2026 23:59
@lwwmanning
lwwmanning enabled auto-merge (squash) November 8, 2026 00:01
@lwwmanning
lwwmanning merged commit 4598f85 into develop Nov 8, 2026
81 checks passed
@lwwmanning
lwwmanning deleted the wm/renovate-js-lock-age branch November 8, 2026 00:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog/chore A trivial change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants