Repository navigation
Explain how to make python security fix within cooldown window - #11034
Conversation
The JS lock-file-maintenance group sets minimumReleaseAge so Renovate passes the 7-day wait to npm as --before. But Renovate also checks that age against the lock refresh itself, which has no release timestamp. Renovate's docs mark npm as not enforcing the age during lock maintenance, so with the default timestamp-required behaviour the renovate/stability-days check stays pending and the branch is never created. Set minimumReleaseAgeBehaviour to timestamp-optional for that group: the update without a timestamp passes the check, and npm's --before still applies the wait. Found by Codex's review of #10997 after it merged. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Will Manning <will@willmanning.io>
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
The root pyproject.toml makes uv skip releases younger than 7 days.
Renovate opens security updates at once, but uv still refuses a fix
that new, so the security PR fails to update uv.lock. Document the
one-line bypass, exclude-newer-package = { <package> = false }, and its
removal once the release ages out. Keeping the cutoff over dropping it
was a deliberate choice: without it, Python lock refreshes would take
releases as soon as they are published.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Signed-off-by: Will Manning <will@willmanning.io>
|
@lwwmanning you will need to rebase this to merge |
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01RY8Dy1iff8nwQScNFY4LvK Signed-off-by: Will Manning <will@willmanning.io>
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 8172f3cf60
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Merging this PR will improve performance by 11.22%1 warning
Performance Changes
Tip Curious why performance improved? Comment Comparing Footnotes
|
Plain uv lock keeps a locked version that still satisfies the constraints, so the security fix needs --upgrade-package. Also say that Cargo.lock refreshes do not wait 7 days. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01RY8Dy1iff8nwQScNFY4LvK Signed-off-by: Will Manning <will@willmanning.io>
The JS lock file group sets
minimumReleaseAge, so Renovate gives npm the 7-day wait as--before. But Renovate also checks that age against the lock refresh itself, and a lock refresh has no release date. Renovate's docs say npm does not enforce the age during lock maintenance. Sorenovate/stability-daysstays pending, and Renovate never creates the branch.This PR sets
minimumReleaseAgeBehaviour: "timestamp-optional"on that group. The check then passes, and npm's--beforestill applies the wait. Codex found this in #10997 after it merged.This PR also adds a section to
CONTRIBUTING.md. uv's 7-day cutoff also blocks a Python security fix that was released in the last 7 days. The section shows the one-line bypass to add to the security PR.🤖 Generated with Claude Code