Skip to content

Rename CI image labels to Ubuntu 26.04 - #10934

Merged
robert3005 merged 2 commits into
developfrom
rk/ubuntu-26.04
Nov 1, 2026
Merged

robert3005 merged 2 commits into
developfrom
rk/ubuntu-26.04

Conversation

@robert3005

Copy link
Copy Markdown
Contributor

Rename the ubuntu24-*-pre-v2 image labels to ubuntu26-*-pre-v2, to match the AMIs that vortex-data/.github-private#39 moves to Ubuntu 26.04. The release binary fallback runner moves to ubuntu-26.04. GPU jobs stay on ubuntu24-gpu-x64 (no 26.04 GPU image upstream).

🤖 Generated with Claude Code

@robert3005
robert3005 force-pushed the rk/ubuntu-26.04 branch 2 times, most recently from 11abd0b to 9211f0c Compare October 28, 2026 16:42
@robert3005 robert3005 added changelog/chore A trivial change changelog/skip Do not list PR in the changelog and removed changelog/chore A trivial change labels Oct 30, 2026
@codspeed

codspeed Bot commented Oct 30, 2026 •

Copy link
Copy Markdown

Merging this PR will degrade performance by 12.55%

2 warnings

⚠️ Walltime results may be unreliable

Some benchmarks used the Walltime instrument outside CodSpeed Macro Runners, which can make the results inconsistent.

Learn more about Macro Runners

See affected benchmarks

⚠️ 9 benchmarks with a significant change ran in a different software environment

Their base and head results were measured with a different OS or toolchain, such as compiler, runtime or library versions, so the changes might come from this difference rather than from the code. Open an affected benchmark to see what changed.

See affected benchmarks

⚡ 1 improved benchmark
❌ 8 regressed benchmarks
✅ 2309 untouched benchmarks

Warning

Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

Mode Benchmark BASE HEAD Efficiency
❌ CPU Simulation take_map[(0.1, 0.5)] 139 µs 174.6 µs -20.37%
❌ CPU Simulation bench_compare_varbin[(50000, 2)] 132.1 µs 160.9 µs -17.9%
❌ CPU Simulation bench_compare_varbin[(50000, 64)] 133.9 µs 163 µs -17.83%
❌ CPU Simulation encode_primitives[u8, (2000, 4)] 135.5 µs 162.5 µs -16.65%
❌ CPU Simulation bench_compare_sliced_dict_varbinview[(1000, 10000)] 76.9 µs 88.7 µs -13.29%
❌ CPU Simulation bench_compare_sliced_dict_varbinview[(7500, 10000)] 198.6 µs 226.9 µs -12.48%
❌ CPU Simulation bench_compare_sliced_dict_varbinview[(10000, 10000)] 204.8 µs 233.2 µs -12.16%
❌ CPU Simulation filter_powerlaw_by_random[10000] 684 ns 764.1 ns -10.49%
⚡ CPU Simulation sixteen_vertex_lines 667.6 µs 596.5 µs +11.92%

Tip

Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.


Comparing rk/ubuntu-26.04 (8fca055) with develop (2b52084)

Open in CodSpeed

The vortex-ci-v2 AMIs move to the RunsOn ubuntu26-full base images
(vortex-data/.github-private#39). Rename the ubuntu24-*-pre-v2 image labels
to ubuntu26-*-pre-v2 and move the release binary fallback runner to
ubuntu-26.04. The GPU jobs stay on ubuntu24-gpu-x64, because RunsOn has no
26.04 GPU image.

Signed-off-by: Robert Kruszewski <github@robertk.io>
Catch2 test macros expand to __COUNTER__. The newer clang on the Ubuntu
26.04 images flags it as a C2y extension under -Wpedantic, and -Werror
makes the FFI test build fail. Disable -Wc2y-extensions for
vortex_ffi_test when the compiler knows the flag.

Signed-off-by: Robert Kruszewski <github@robertk.io>
@robert3005
robert3005 merged commit f6d3413 into develop Nov 1, 2026
75 of 76 checks passed
@robert3005
robert3005 deleted the rk/ubuntu-26.04 branch November 1, 2026 00:04
robert3005 added a commit that referenced this pull request Nov 1, 2026
#10934 renamed the Linux CI image labels to
`ubuntu26-full-{x64,arm64}-pre-v2`, but the `name` patterns in
`.github/runs-on.yml` still match the old AMIs:

| label | pattern before | AMI that CI boots |
|---|---|---|
| `ubuntu26-full-x64-pre-v2` | `vortex-ci-v2-x64-*` |
`vortex-ci-v2-x64-20261030180912` (old cloud-init image) |
| `ubuntu26-full-arm64-pre-v2` | `vortex-ci-v2-arm64-*` | old cloud-init
image |

The AMI build in `.github-private` now publishes
`vortex-ci-v2-ubuntu26-{x64,arm64}-*`. This PR changes the patterns to
match those names.

Signed-off-by: Robert Kruszewski <github@robertk.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog/skip Do not list PR in the changelog

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants