Repository navigation
Rename CI image labels to Ubuntu 26.04 - #10934
Conversation
11abd0b to
9211f0c
Compare
9211f0c to
814b074
Compare
Merging this PR will degrade performance by 12.55%2 warnings
Warning Please fix the performance issues or acknowledge them on CodSpeed. Performance Changes
Tip Investigate this regression by commenting Comparing |
The vortex-ci-v2 AMIs move to the RunsOn ubuntu26-full base images (vortex-data/.github-private#39). Rename the ubuntu24-*-pre-v2 image labels to ubuntu26-*-pre-v2 and move the release binary fallback runner to ubuntu-26.04. The GPU jobs stay on ubuntu24-gpu-x64, because RunsOn has no 26.04 GPU image. Signed-off-by: Robert Kruszewski <github@robertk.io>
814b074 to
175e0d0
Compare
Catch2 test macros expand to __COUNTER__. The newer clang on the Ubuntu 26.04 images flags it as a C2y extension under -Wpedantic, and -Werror makes the FFI test build fail. Disable -Wc2y-extensions for vortex_ffi_test when the compiler knows the flag. Signed-off-by: Robert Kruszewski <github@robertk.io>
#10934 renamed the Linux CI image labels to `ubuntu26-full-{x64,arm64}-pre-v2`, but the `name` patterns in `.github/runs-on.yml` still match the old AMIs: | label | pattern before | AMI that CI boots | |---|---|---| | `ubuntu26-full-x64-pre-v2` | `vortex-ci-v2-x64-*` | `vortex-ci-v2-x64-20261030180912` (old cloud-init image) | | `ubuntu26-full-arm64-pre-v2` | `vortex-ci-v2-arm64-*` | old cloud-init image | The AMI build in `.github-private` now publishes `vortex-ci-v2-ubuntu26-{x64,arm64}-*`. This PR changes the patterns to match those names. Signed-off-by: Robert Kruszewski <github@robertk.io>
Rename the
ubuntu24-*-pre-v2image labels toubuntu26-*-pre-v2, to match the AMIs that vortex-data/.github-private#39 moves to Ubuntu 26.04. The release binary fallback runner moves toubuntu-26.04. GPU jobs stay onubuntu24-gpu-x64(no 26.04 GPU image upstream).🤖 Generated with Claude Code