Skip to content

[DRAFT, do not merge] Run all SQL benchmarks on the V2 scan - #10898

Closed
joseph-isaacs wants to merge 1 commit into
developfrom
ji/bench-scan-v2-all
Closed

joseph-isaacs wants to merge 1 commit into
developfrom
ji/bench-scan-v2-all

Conversation

@joseph-isaacs

Copy link
Copy Markdown
Contributor

Summary

An experiment to see how the planner-driven V2 Vortex scan performs across every SQL benchmark, not only TPC-H, where it is already the default. Only the Python orchestrator changes. The Rust benchmark binaries and their defaults stay as they are.

Changes

  • bench-orchestrator/bench_orchestrator/runner/executor.py: build_command now passes --scan-v2 true to datafusion-bench and duckdb-bench. Lance does not get the flag.
  • bench-orchestrator/tests/test_executor.py: checks that the DuckDB command includes the flag and the Lance command leaves it out.

Checks run: uv run --with pytest python -m pytest -q tests in bench-orchestrator/ (34 passed).


Generated by Claude Code

Loading
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog/skip Do not list PR in the changelog

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant