Repository navigation
[DRAFT, do not merge] Run all SQL benchmarks on the V2 scan - #10898
Closed
joseph-isaacs wants to merge 1 commit into
Closed
joseph-isaacs wants to merge 1 commit into
joseph-isaacs wants to merge 1 commit into
Conversation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
An experiment to see how the planner-driven V2 Vortex scan performs across every SQL benchmark, not only TPC-H, where it is already the default. Only the Python orchestrator changes. The Rust benchmark binaries and their defaults stay as they are.
Changes
bench-orchestrator/bench_orchestrator/runner/executor.py:build_commandnow passes--scan-v2 truetodatafusion-benchandduckdb-bench. Lance does not get the flag.bench-orchestrator/tests/test_executor.py: checks that the DuckDB command includes the flag and the Lance command leaves it out.Checks run:
uv run --with pytest python -m pytest -q testsinbench-orchestrator/(34 passed).Generated by Claude Code