Repository navigation
docs(cuda): clarify mapped-page eviction - #10882
Conversation
|
@claude review this pr in depth |
|
Claude finished @0ax1's task in 56s —— View job Review: docs(cuda): describe what keeps mapped files in the page cacheThe old wording was wrong. Mapped pages aren't pinned, and memory pressure reclaims them like any other clean file page, so fixing it is worthwhile. I found one real accuracy gap in the new wording and two small nits. 1.
|
Merging this PR will not alter performance1 warning
Comparing Footnotes
|
`release_file_mappings` and `vx_cuda_release_file_mappings` said mapped pages cannot be dropped from the page cache. Mapped pages are not locked: memory pressure reclaims them as usual. Only `posix_fadvise(DONTNEED)`, which cold-cache measurements use to evict files, skips pages mapped into a process, which is why the mappings must be released first. Say so. Signed-off-by: Alexander Droste <alexander.droste@protonmail.com>
Signed-off-by: Alexander Droste <alexander.droste@protonmail.com>
e4c993d to
f81c155
Compare
Summary
Corrects the documentation for release_file_mappings and
vx_cuda_release_file_mappings. Keeping a file mapped does not pin its
pages in memory: memory pressure can still reclaim them.
On Linux, both posix_fadvise(POSIX_FADV_DONTNEED) and
/proc/sys/vm/drop_caches skip pages mapped into a process. Release
Vortex's cached mappings before using either for cold-cache measurements.
Mappings still used by open readers remain mapped until those readers
are released.
Changes
distinction between explicit cache eviction and memory-pressure reclaim.
Documentation only; no runtime behavior changes. No builds, tests, or
benchmarks were run.