Repository navigation
refactor(cuda): slice mutable views through one implementation - #10880
Conversation
|
@claude review this pr in depth |
|
Claude finished @0ax1's task in 50s —— View job Review of #10880:
|
Merging this PR will degrade performance by 12.5%1 warning
Warning Please fix the performance issues or acknowledge them on CodSpeed. Performance Changes
Tip Investigate this regression by commenting Comparing Footnotes
|
`CudaViewMut::slice_mut` repeated the body of `into_slice_mut`. Reslice a copy of the view, borrowed for as long as the result, instead. Signed-off-by: Alexander Droste <alexander.droste@protonmail.com>
Signed-off-by: Alexander Droste <alexander.droste@protonmail.com>
7d93fcb to
570df9d
Compare
Summary
Removes duplicate mutable-view slicing logic by making
CudaViewMut::slice_mut delegate to into_slice_mut.
The temporary copies only view metadata, not device data. The return
lifetime keeps the original view mutably borrowed while the result lives.
Bounds checks, panic messages, pointer arithmetic, and access tracking
remain unchanged.
Changes
No performance impact is expected: this adds no allocation, CUDA calls,
synchronization, or device-data copies. Optimized builds should eliminate
the temporary view and inline the helper.
No builds, tests, or benchmarks were run for this change.