Repository navigation
Read Vortex file column statistics through vortex-jni - #10863
Merged
Merged
Conversation
Add NativeFiles.readStatistics for a URI and for a NativeReadable. Both return the per-column statistics stored in the file footer and read no column data. Move the statistics-to-Java conversion out of the writer into a shared module so writes and reads use the same code. Signed-off-by: Robert Kruszewski <github@robertk.io> Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Resolve each column statistic through the file's DataSource. Use the stored aggregate partial from field_statistic first, and read the finalized legacy statistics from field_statistics only when a statistic has no partial, for example in a file written before partials were stored. Signed-off-by: Robert Kruszewski <github@robertk.io> Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
robert3005
force-pushed
the
rk/jni-file-statistics
branch
from
November 2, 2026 14:36
0911e01 to
2b3c453
Compare
Merging this PR will degrade performance by 22.48%2 warnings
Warning Please fix the performance issues or acknowledge them on CodSpeed. Performance Changes
Tip Investigate this regression by commenting Comparing |
myrrc
approved these changes
Nov 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds per-file statistics reads to the Java bindings. The statistics come from the file footer, so no column data is read.
NativeFiles.readStatistics(Session, String uri, Map<String, String> options)returnsList<VortexColumnStatistics>.NativeFiles.readStatistics(Session, NativeReadable)does the same through caller-provided I/O.DataSource. The stored aggregate partial fromfield_statisticcomes first. The finalized legacy statistics fromfield_statisticsare used only when a statistic has no partial, for example in a file written before partials were stored.