Skip to content

Expose aggregate statistics via Scan API - #10838

Merged
gatesn merged 6 commits into
developfrom
ngates/scan-aggregate-statistics-review
Oct 26, 2026
Merged

gatesn merged 6 commits into
developfrom
ngates/scan-aggregate-statistics-review

Conversation

@gatesn

@gatesn gatesn commented Oct 26, 2026

Copy link
Copy Markdown
Contributor

Returns arbitrary aggregate function partials for a given field path. This allows callers to probe for any statistics.

To consider:

  • Exposing this as a batch endpoint? (Vec -> Vec<Precision>)
  • Deprecate the field_statistics function

Signed-off-by: Nicholas Gates <nick@nickgates.com>
Signed-off-by: Nicholas Gates <nick@nickgates.com>
Signed-off-by: Nicholas Gates <nick@nickgates.com>
Signed-off-by: Nicholas Gates <nick@nickgates.com>
Signed-off-by: Nicholas Gates <nick@nickgates.com>
Signed-off-by: Nicholas Gates <nick@nickgates.com>
@codspeed

codspeed Bot commented Oct 26, 2026 •

Copy link
Copy Markdown

Merging this PR will degrade performance by 4.73%

4 warnings, 1 note

⚠️ Walltime results may be unreliable

Some benchmarks used the Walltime instrument outside CodSpeed Macro Runners, which can make the results inconsistent.

Learn more about Macro Runners

See affected benchmarks

⚠️ Unable to measure the execution of 1 benchmark

This benchmark measured no execution time, so its result is not comparable and counts as unchanged. This usually happens when the compiler removes the code under test.

Prevent compiler optimizations

See affected benchmarks

⚠️ 17 benchmarks are dominated by system calls

System calls cannot be simulated consistently and are left out of the measure. The reported value understates the real cost. Switch to the Walltime instrument to measure them.

Learn more about system calls

See affected benchmarks

⚠️ Base and head ran on different runner types

Some benchmarks with significant performance changes were compared across different runner types, so the changes might not come from the code. Run base and head on the same runner type, or use CodSpeed Macro Runners for more stable results.

Learn more about Macro Runners

Open the report in CodSpeed to investigate

ℹ️ 40 benchmarks have no flamegraph

The flamegraph wasn't generated: the symbols of the profiling trace could not be resolved, because no information about the language frames was collected.

See affected benchmarks

⚡ 5 improved benchmarks
❌ 3 regressed benchmarks
✅ 2431 untouched benchmarks
⏩ 12 skipped benchmarks1

Warning

Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

Mode Benchmark BASE HEAD Efficiency
❌ Walltime threshold_neon[8] 1.4 µs 2.3 µs -38.25%
❌ CPU Simulation chunked_dict_primitive_canonical_into[f64, (1000, 1000, 10)] 146.7 µs 200.8 µs -26.93%
❌ Walltime threshold_neon[64] 2.6 µs 3.3 µs -20.3%
⚡ CPU Simulation test_scan_filter_to_arrow_array[int_float] 4 ms 3.5 ms +15.77%
⚡ CPU Simulation test_scan_filter_to_arrow_array[int] 2.8 ms 2.5 ms +14.23%
⚡ CPU Simulation test_scan_filter[int] 3.5 ms 3.1 ms +13.32%
⚡ CPU Simulation test_repeated_scan_filter[int] 2.7 ms 2.4 ms +12.25%
⚡ CPU Simulation test_repeated_scan_filter[int_float] 3.8 ms 3.4 ms +12.22%

Tip

Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.


Comparing ngates/scan-aggregate-statistics-review (e32ec37) with develop (967e2f5)

Open in CodSpeed

Footnotes

  1. 12 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

@gatesn gatesn added the changelog/feature A new feature label Oct 26, 2026
@gatesn
gatesn marked this pull request as ready for review October 26, 2026 20:09
@gatesn
gatesn enabled auto-merge (squash) October 26, 2026 20:09
@gatesn
gatesn merged commit a59294e into develop Oct 26, 2026
108 of 110 checks passed
@gatesn
gatesn deleted the ngates/scan-aggregate-statistics-review branch October 26, 2026 20:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog/feature A new feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants