Skip to content

DataFusion v2 expression converter injection - #10836

Merged
gatesn merged 2 commits into
developfrom
ngates/expression-converter-injection
Oct 26, 2026
Merged

gatesn merged 2 commits into
developfrom
ngates/expression-converter-injection

Conversation

@gatesn

@gatesn gatesn commented Oct 26, 2026

Copy link
Copy Markdown
Contributor

Allow passing a custom expression converter into the V2 DataFusion VortexDataSource

Signed-off-by: Nicholas Gates <nick@nickgates.com>
Signed-off-by: Nicholas Gates <nick@nickgates.com>
@gatesn gatesn added the changelog/fix A bug fix label Oct 26, 2026
@gatesn
gatesn enabled auto-merge (squash) October 26, 2026 19:26
@gatesn
gatesn merged commit 8fc66b8 into develop Oct 26, 2026
108 of 110 checks passed
@gatesn
gatesn deleted the ngates/expression-converter-injection branch October 26, 2026 19:34
@codspeed

codspeed Bot commented Oct 26, 2026

Copy link
Copy Markdown

Merging this PR will regress 2 benchmarks

4 warnings, 1 note

⚠️ Walltime results may be unreliable

Some benchmarks used the Walltime instrument outside CodSpeed Macro Runners, which can make the results inconsistent.

Learn more about Macro Runners

See affected benchmarks

⚠️ Unable to measure the execution of 2 benchmarks

These benchmarks measured no execution time, so their results are not comparable and count as unchanged. This usually happens when the compiler removes the code under test.

Prevent compiler optimizations

See affected benchmarks

⚠️ 21 benchmarks are dominated by system calls

System calls cannot be simulated consistently and are left out of the measure. The reported value understates the real cost. Switch to the Walltime instrument to measure them.

Learn more about system calls

See affected benchmarks

⚠️ Base and head ran on different runner types

Some benchmarks with significant performance changes were compared across different runner types, so the changes might not come from the code. Run base and head on the same runner type, or use CodSpeed Macro Runners for more stable results.

Learn more about Macro Runners

Open the report in CodSpeed to investigate

ℹ️ 40 benchmarks have no flamegraph

The flamegraph wasn't generated: the symbols of the profiling trace could not be resolved, because no information about the language frames was collected.

See affected benchmarks

⚡ 6 improved benchmarks
❌ 2 regressed benchmarks
✅ 2431 untouched benchmarks
⏩ 12 skipped benchmarks1

Warning

Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

Mode Benchmark BASE HEAD Efficiency
❌ CPU Simulation chunked_dict_primitive_canonical_into[f64, (1000, 1000, 10)] 146.6 µs 200.8 µs -26.99%
❌ CPU Simulation test_scan_scalar_at[int_str] 953.1 µs 1,068.8 µs -10.83%
⚡ CPU Simulation bench_compare_sliced_dict_primitive[(3333, 10000)] 71.1 µs 33 µs ×2.2
⚡ Walltime threshold_neon[8] 1.9 µs 1.4 µs +42.67%
⚡ Walltime threshold_neon[64] 3.5 µs 2.6 µs +33.08%
⚡ CPU Simulation filter_powerlaw_by_random[250000] 174.3 µs 131.3 µs +32.74%
⚡ Walltime threshold_neon[80] 4.2 µs 3.4 µs +24.4%
⚡ CPU Simulation decompress[u16, (4000, 256)] 61 µs 54.7 µs +11.59%

Tip

Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.


Comparing ngates/expression-converter-injection (14c63fa) with develop (4d0eccd)

Open in CodSpeed

Footnotes

  1. 12 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog/fix A bug fix

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants