Skip to content

Remove unused dictionary layout metadata - #10823

Merged
connortsui20 merged 1 commit into
developfrom
ct/remove-unused-dict-layout-metadata
Oct 26, 2026
Merged

connortsui20 merged 1 commit into
developfrom
ct/remove-unused-dict-layout-metadata

Conversation

@connortsui20

Copy link
Copy Markdown
Member

Summary

The writer’s unused copy of DictLayoutMetadata recommends prost’s lenient enum getter.

Changes

Remove the duplicate and its constructor. The active dictionary layout metadata is unchanged.

API Changes

Removes vortex_layout::layouts::dict::writer::DictLayoutMetadata.

Signed-off-by: Connor Tsui <connor.tsui20@gmail.com>
@connortsui20 connortsui20 added the changelog/chore A trivial change label Oct 26, 2026 — with ChatGPT Codex Connector
@codspeed

codspeed Bot commented Oct 26, 2026

Copy link
Copy Markdown

Merging this PR will improve performance by 36.93%

4 warnings, 1 note

⚠️ Walltime results may be unreliable

Some benchmarks used the Walltime instrument outside CodSpeed Macro Runners, which can make the results inconsistent.

Learn more about Macro Runners

See affected benchmarks

⚠️ Unable to measure the execution of 2 benchmarks

These benchmarks measured no execution time, so their results are not comparable and count as unchanged. This usually happens when the compiler removes the code under test.

Prevent compiler optimizations

See affected benchmarks

⚠️ 22 benchmarks are dominated by system calls

System calls cannot be simulated consistently and are left out of the measure. The reported value understates the real cost. Switch to the Walltime instrument to measure them.

Learn more about system calls

See affected benchmarks

⚠️ Base and head ran on different runner types

Some benchmarks with significant performance changes were compared across different runner types, so the changes might not come from the code. Run base and head on the same runner type, or use CodSpeed Macro Runners for more stable results.

Learn more about Macro Runners

Open the report in CodSpeed to investigate

ℹ️ 40 benchmarks have no flamegraph

The flamegraph wasn't generated: the symbols of the profiling trace could not be resolved, because no information about the language frames was collected.

See affected benchmarks

⚡ 1 improved benchmark
✅ 2438 untouched benchmarks
⏩ 12 skipped benchmarks1

Performance Changes

Mode Benchmark BASE HEAD Efficiency
⚡ CPU Simulation chunked_dict_primitive_canonical_into[f64, (1000, 1000, 10)] 200.5 µs 146.4 µs +36.93%

Tip

Curious why performance improved? Comment @codspeedbot explain why performance improved on this PR, or directly use the CodSpeed MCP with your agent.


Comparing ct/remove-unused-dict-layout-metadata (143bee6) with develop (33675d9)

Open in CodSpeed

Footnotes

  1. 12 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

@connortsui20
connortsui20 marked this pull request as ready for review October 26, 2026 18:25
@connortsui20
connortsui20 merged commit 0db53f9 into develop Oct 26, 2026
109 of 110 checks passed
@connortsui20
connortsui20 deleted the ct/remove-unused-dict-layout-metadata branch October 26, 2026 18:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog/chore A trivial change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants