Skip to content

Pass VortexSession to plan scan and optimizer - #10794

Merged
myrrc merged 2 commits into
developfrom
myrrc/scan-session
Oct 26, 2026
Merged

myrrc merged 2 commits into
developfrom
myrrc/scan-session

Conversation

@myrrc

@myrrc myrrc commented Oct 26, 2026

Copy link
Copy Markdown
Contributor

This is needed for adding a dynamic registry for partitioning rules

Signed-off-by: Mikhail Kot <mikhail@spiraldb.com>
@myrrc
myrrc requested a review from robert3005 October 26, 2026 10:43
@myrrc myrrc added the changelog/feature A new feature label Oct 26, 2026
@myrrc
myrrc enabled auto-merge (squash) October 26, 2026 10:43
@codspeed

codspeed Bot commented Oct 26, 2026 •

Copy link
Copy Markdown

Merging this PR will improve performance by 13.44%

2 warnings, 1 note

⚠️ Walltime results may be unreliable

Some benchmarks used the Walltime instrument outside CodSpeed Macro Runners, which can make the results inconsistent.

Learn more about Macro Runners

See affected benchmarks

⚠️ 66 benchmarks are dominated by system calls

System calls cannot be simulated consistently and are left out of the measure. The reported value understates the real cost. Switch to the Walltime instrument to measure them.

Learn more about system calls

See affected benchmarks

ℹ️ 40 benchmarks have no flamegraph

The flamegraph wasn't generated: the symbols of the profiling trace could not be resolved, because no information about the language frames was collected.

See affected benchmarks

⚡ 1 improved benchmark
✅ 2407 untouched benchmarks
⏩ 12 skipped benchmarks1

Performance Changes

Mode Benchmark BASE HEAD Efficiency
⚡ Walltime words_gather_dispatch_avx512[65536] 979 ns 863 ns +13.44%

Tip

Curious why performance improved? Comment @codspeedbot explain why performance improved on this PR, or directly use the CodSpeed MCP with your agent.


Comparing myrrc/scan-session (1fdab7f) with develop (1dba73c)

Open in CodSpeed

Footnotes

  1. 12 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

Signed-off-by: Mikhail Kot <mikhail@spiraldb.com>
@myrrc
myrrc disabled auto-merge October 26, 2026 12:25
@myrrc
myrrc merged commit 6007f56 into develop Oct 26, 2026
88 of 89 checks passed
@myrrc
myrrc deleted the myrrc/scan-session branch October 26, 2026 12:25
@joseph-isaacs joseph-isaacs mentioned this pull request Nov 9, 2026
16 of 46 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog/feature A new feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants