Skip to content

Add compat fixtures for old decimal forms - #10753

Merged
connortsui20 merged 4 commits into
developfrom
ct/decimal-compat-fixtures
Oct 26, 2026
Merged

connortsui20 merged 4 commits into
developfrom
ct/decimal-compat-fixtures

Conversation

@connortsui20

Copy link
Copy Markdown
Member

Summary

Adds compat fixtures for the old decimal forms that current writers still produce: decimals stored narrower than the canonical width of their precision (including values that need the next precision, and high scales), decimals stored wider, nonzero values in null slots, and DecimalByteParts with narrow and wide most significant parts. A release must publish these files before #10701 changes how old decimal arrays read, so that the new read path is checked against real old files.

Changes

A flat fixture can now override build_written() to write a physical form that build() must not return. generate and publish write build_written(), and check compares each published file with build(), which returns canonical arrays only. So the published file keeps the old form while the expected array never changes. The overrides work only while DecimalArray::try_new accepts a non-canonical width. Once it rejects one, the overrides must be deleted, and the files published before that keep the old forms. DESIGN.md documents the hook.

The new tests check that every decimal in build() has the canonical width and that every written column keeps its stored width through a file round trip. That round-trip check reads with the current reader, so the change in #10701 that converts old decimal arrays on read must update it. Until a release publishes the new fixtures, compat.py check --mode last skips them.

🤖 Generated with Claude Code

@codspeed

codspeed Bot commented Oct 23, 2026 •

Copy link
Copy Markdown

Merging this PR will regress 1 benchmark

3 warnings, 1 note

⚠️ Walltime results may be unreliable

Some benchmarks used the Walltime instrument outside CodSpeed Macro Runners, which can make the results inconsistent.

Learn more about Macro Runners

See affected benchmarks

⚠️ Unable to measure the execution of 1 benchmark

This benchmark measured no execution time, so its result is not comparable and counts as unchanged. This usually happens when the compiler removes the code under test.

Prevent compiler optimizations

See affected benchmarks

⚠️ 20 benchmarks are dominated by system calls

System calls cannot be simulated consistently and are left out of the measure. The reported value understates the real cost. Switch to the Walltime instrument to measure them.

Learn more about system calls

See affected benchmarks

ℹ️ 40 benchmarks have no flamegraph

The flamegraph wasn't generated: the symbols of the profiling trace could not be resolved, because no information about the language frames was collected.

See affected benchmarks

⚡ 4 improved benchmarks
❌ 1 regressed benchmark
✅ 2403 untouched benchmarks
⏩ 12 skipped benchmarks1

Warning

Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

Mode Benchmark BASE HEAD Efficiency
❌ CPU Simulation chunked_dict_primitive_canonical_into[f64, (1000, 1000, 10)] 149 µs 203 µs -26.6%
⚡ Walltime filter_neon[8] 1,115 ns 882 ns +26.42%
⚡ CPU Simulation test_repeated_scan_scalar_at[int] 280.2 µs 235.5 µs +19.01%
⚡ Walltime filter_neon[64] 2 µs 1.7 µs +13.63%
⚡ Walltime filter_neon[80] 2.7 µs 2.4 µs +12.63%

Tip

Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.


Comparing ct/decimal-compat-fixtures (17d44f1) with develop (f3cbb32)

Open in CodSpeed

Footnotes

  1. 12 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

@connortsui20
connortsui20 marked this pull request as ready for review October 23, 2026 20:57
@connortsui20

Copy link
Copy Markdown
Member Author

honestly I have no idea if these changes are correct, am not familiar with how these fixtures are supposed to work

@robert3005

Copy link
Copy Markdown
Contributor

Apologies I change ci, you will need to rebase

Signed-off-by: Connor Tsui <connor.tsui20@gmail.com>
Signed-off-by: Connor Tsui <connor.tsui20@gmail.com>
Signed-off-by: Connor Tsui <connor.tsui20@gmail.com>
Signed-off-by: Connor Tsui <connor.tsui20@gmail.com>
@connortsui20
connortsui20 force-pushed the ct/decimal-compat-fixtures branch from b33287c to 17d44f1 Compare October 26, 2026 14:05
@connortsui20
connortsui20 enabled auto-merge (squash) October 26, 2026 14:05
@connortsui20
connortsui20 merged commit 3c6cd69 into develop Oct 26, 2026
81 of 83 checks passed
@connortsui20
connortsui20 deleted the ct/decimal-compat-fixtures branch October 26, 2026 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog/chore A trivial change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants