Skip to content

Pass an execution context to array value display - #10583

Merged
myrrc merged 3 commits into
developfrom
rk/legacy-session-display
Oct 19, 2026
Merged

myrrc merged 3 commits into
developfrom
rk/legacy-session-display

Conversation

@robert3005

@robert3005 robert3005 commented Oct 18, 2026 •

Copy link
Copy Markdown
Contributor

Displaying array values executes the array, so it now takes the caller's execution context instead of reaching for a global session.

part of #9446

Display cannot receive an execution context, so build one from a default
array session for each format call and reuse it across all rows instead of
reaching for the hidden global `legacy_session()`.

Signed-off-by: Claude <noreply@anthropic.com>

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Y1zHpE1K1Y9HvyU4kt24Tq
@codspeed

codspeed Bot commented Oct 18, 2026 •

Copy link
Copy Markdown

Merging this PR will degrade performance by 11.14%

⚠️ Unknown Walltime execution environment detected

Using the Walltime instrument on standard Hosted Runners will lead to inconsistent data.

For the most accurate results, we recommend using CodSpeed Macro Runners: bare-metal machines fine-tuned for performance measurement consistency.

⚠️ 21 benchmarks spent significant time in system calls

System calls cannot be consistently instrumented, so they are not included in the measure, which understates the real cost. Please switch to the Walltime instrument to accurately measure system calls.

Measurement and system calls

ℹ️ 40 benchmarks have no flame graph

The flamegraph could not be generated because we failed to resolve the symbols in the profiling trace. This happens when we fail to harvest information about language frames.

⚠️ Different runtime environments detected

Some benchmarks with significant performance changes were compared across different runtime environments,
which may affect the accuracy of the results.

Open the report in CodSpeed to investigate

⚡ 2 improved benchmarks
❌ 5 regressed benchmarks
✅ 2401 untouched benchmarks
⏩ 12 skipped benchmarks1

Warning

Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

Mode Benchmark BASE HEAD Efficiency
❌ ⚠️ Simulation random_i128[0.01] 3.8 µs 5.8 µs -34.38%
❌ Simulation random_i8[0.01] 100.6 µs 132.7 µs -24.18%
❌ Simulation sum_v2_i64 194.2 µs 224.7 µs -13.57%
❌ Simulation sum_i64 194.7 µs 224.6 µs -13.33%
❌ WallTime bitpack_blocked_compress_avx2 6.7 µs 7.6 µs -11.42%
⚡ WallTime bitpack_blocked_compress_avx512 5.6 µs 4.8 µs +16.91%
⚡ WallTime starts_with_avx2[8, VarBin] 46.6 µs 41.1 µs +13.35%

Tip

Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.


Comparing rk/legacy-session-display (0c7f415) with develop (5fc5cb8)

Open in CodSpeed

Footnotes

  1. 12 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

Displaying array values executes the array, so `display_values`, `display_as`
and `display_table` now take an `ExecutionCtx` instead of reaching for the
global session. The plain `Display` impl of `ArrayRef` only writes the
encoding summary, which needs no execution.

Signed-off-by: Claude <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Y1zHpE1K1Y9HvyU4kt24Tq
@robert3005 robert3005 changed the title Format array values without the legacy session Pass an execution context to array value display Oct 18, 2026
Signed-off-by: Claude <noreply@anthropic.com>

# Conflicts:
#	vortex-array/src/arrays/masked/vtable/mod.rs
#	vortex-array/src/arrays/patched/vtable/mod.rs
@robert3005 robert3005 added the changelog/break A breaking API change label Oct 19, 2026
@robert3005
robert3005 marked this pull request as ready for review October 19, 2026 10:33
@myrrc
myrrc merged commit d907f6e into develop Oct 19, 2026
160 of 164 checks passed
@myrrc
myrrc deleted the rk/legacy-session-display branch October 19, 2026 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog/break A breaking API change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants