Repository navigation
Pass an execution context to array value display - #10583
Conversation
Display cannot receive an execution context, so build one from a default array session for each format call and reuse it across all rows instead of reaching for the hidden global `legacy_session()`. Signed-off-by: Claude <noreply@anthropic.com> Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Y1zHpE1K1Y9HvyU4kt24Tq
Merging this PR will degrade performance by 11.14%
|
| Mode | Benchmark | BASE |
HEAD |
Efficiency | |
|---|---|---|---|---|---|
| ❌ |
Simulation | random_i128[0.01] |
3.8 µs | 5.8 µs | -34.38% |
| ❌ | Simulation | random_i8[0.01] |
100.6 µs | 132.7 µs | -24.18% |
| ❌ | Simulation | sum_v2_i64 |
194.2 µs | 224.7 µs | -13.57% |
| ❌ | Simulation | sum_i64 |
194.7 µs | 224.6 µs | -13.33% |
| ❌ | WallTime | bitpack_blocked_compress_avx2 |
6.7 µs | 7.6 µs | -11.42% |
| ⚡ | WallTime | bitpack_blocked_compress_avx512 |
5.6 µs | 4.8 µs | +16.91% |
| ⚡ | WallTime | starts_with_avx2[8, VarBin] |
46.6 µs | 41.1 µs | +13.35% |
Tip
Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.
Comparing rk/legacy-session-display (0c7f415) with develop (5fc5cb8)
Footnotes
-
12 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩
Displaying array values executes the array, so `display_values`, `display_as` and `display_table` now take an `ExecutionCtx` instead of reaching for the global session. The plain `Display` impl of `ArrayRef` only writes the encoding summary, which needs no execution. Signed-off-by: Claude <noreply@anthropic.com> Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Y1zHpE1K1Y9HvyU4kt24Tq
Signed-off-by: Claude <noreply@anthropic.com> # Conflicts: # vortex-array/src/arrays/masked/vtable/mod.rs # vortex-array/src/arrays/patched/vtable/mod.rs
Displaying array values executes the array, so it now takes the caller's execution context instead of reaching for a global session.
part of #9446