Repository navigation
Add an unstable edition that includes all unreleased and upcoming encodings - #10558
Conversation
96e4a1d to
0d13017
Compare
Merging this PR will degrade performance by 13.13%4 warnings, 1 note
Warning Please fix the performance issues or acknowledge them on CodSpeed. Performance Changes
Tip Investigate this regression by commenting Comparing Footnotes
|
0d13017 to
06add6b
Compare
06add6b to
4dcaa60
Compare
Polar Signals Profiling ResultsLatest Run
Powered by Polar Signals Cloud |
Benchmarks: PolarSignals Profiling 📖Commits: PR datafusion / vortex-file-compressed / ns (1.004x ➖, 0↑ 0↓)
No file size changes detected. |
Benchmarks: FineWeb NVMe 📖Commits: PR How to read Verdict and Engines
datafusion / vortex-file-compressed / ns (1.007x ➖, 1↑ 1↓)
datafusion / parquet / ns (0.987x ➖, 0↑ 0↓)
duckdb / vortex-file-compressed / ns (1.005x ➖, 0↑ 0↓)
duckdb / parquet / ns (1.001x ➖, 0↑ 0↓)
No file size changes detected. |
Benchmarks: TPC-H SF=1 on NVME 📖Commits: PR How to read Verdict and Engines
datafusion / vortex-file-compressed / ns (0.996x ➖, 0↑ 0↓)
datafusion / parquet / ns (1.004x ➖, 0↑ 0↓)
duckdb / vortex-file-compressed / ns (1.004x ➖, 0↑ 0↓)
duckdb / parquet / ns (1.009x ➖, 0↑ 0↓)
No file size changes detected. |
Benchmarks: TPC-H SF=10 on NVME 📖Commits: PR How to read Verdict and Engines
datafusion / vortex-file-compressed / ns (0.999x ➖, 0↑ 0↓)
datafusion / parquet / ns (1.001x ➖, 0↑ 0↓)
duckdb / vortex-file-compressed / ns (0.999x ➖, 0↑ 0↓)
duckdb / parquet / ns (0.993x ➖, 0↑ 0↓)
No file size changes detected. |
Benchmarks: Clickbench on NVME 📖Commits: PR How to read Verdict and Engines
datafusion / vortex-file-compressed / ns (0.997x ➖, 0↑ 0↓)
datafusion / parquet / ns (0.996x ➖, 0↑ 0↓)
duckdb / vortex-file-compressed / ns (0.994x ➖, 0↑ 0↓)
duckdb / parquet / ns (0.983x ➖, 0↑ 0↓)
No file size changes detected. |
Benchmarks: TPC-DS SF=1 on NVME 📖Commits: PR How to read Verdict and Engines
datafusion / vortex-file-compressed / ns (0.995x ➖, 0↑ 1↓)
datafusion / parquet / ns (1.000x ➖, 0↑ 0↓)
duckdb / vortex-file-compressed / ns (0.993x ➖, 0↑ 0↓)
duckdb / parquet / ns (0.993x ➖, 0↑ 0↓)
No file size changes detected. |
|
@mhk197 I think this is ready. I will make a follow up to add it to the fuzzer and we should enable it in benchmarks. Wasn't sure if all the encodings are ready or we should remove some of them from the list since they're still wip |
Benchmarks: TPC-H SF=1 on S3 📖Commits: PR How to read Verdict and Engines
datafusion / vortex-file-compressed / ns (0.911x ➖, 2↑ 1↓)
datafusion / parquet / ns (0.961x ➖, 1↑ 1↓)
duckdb / vortex-file-compressed / ns (1.040x ➖, 0↑ 1↓)
duckdb / parquet / ns (0.989x ➖, 1↑ 2↓)
|
|
@robert3005 we still dont have all compute kernels for bitpacked and for v2, but from benchmark perf we should be able to tell if that's a major problem |
|
👍 since this an edition change |
ea0b380 to
1266323
Compare
Signed-off-by: Robert Kruszewski <github@robertk.io>
Remove the separate unstable flag. A draft edition has no recorded min_library_version, and its members can change or be removed. UNSTABLE is a draft in its own family and validation keeps it a draft. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Robert Kruszewski <github@robertk.io>
Remove the special cases that matched UNSTABLE in EditionId::validate and Display. UNSTABLE is now unstable2026.10.0, and the freezes field alone marks it as an edition that never freezes. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Robert Kruszewski <github@robertk.io>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Robert Kruszewski <github@robertk.io>
CI excludes xtask from its test runs, and the generate-editions and check-editions jobs already exercise the record checks. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Robert Kruszewski <github@robertk.io>
Encodings that are not ready for a wire contract should not need an edition. Remove the coverage test that required one, and register PiecewiseSequence in the default session again, as on develop. Also remove preview_starts_empty, which pinned a draft that may change, and fix a redundant rustdoc link. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Robert Kruszewski <github@robertk.io>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Robert Kruszewski <github@robertk.io>
1266323 to
2c8a309
Compare
UNSTABLE exists to aggregate all core encodings that are in the works and should
be tested and benchmarked but not written by default writer