Repository navigation
feat(scan): a planning driver for planners and morsels - #10549
joseph-isaacs wants to merge 1 commit into
Conversation
Runs planners and morsels on the planning protocol, publishes their IO through an `IoService`, and traces their work. Nothing drives it until the V2 scan. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Hai26WGsNERxRHXpA3JboE Signed-off-by: Claude <noreply@anthropic.com>
Merging this PR will degrade performance by 5.08%
|
| Mode | Benchmark | BASE |
HEAD |
Efficiency | |
|---|---|---|---|---|---|
| ❌ |
Simulation | density_sweep_dense_runs[0.001] |
29.4 µs | 46.7 µs | -37.16% |
| ❌ | Simulation | random_i8[0.01] |
103.8 µs | 132.6 µs | -21.68% |
| ❌ | WallTime | threshold_neon[80] |
3.7 µs | 4.5 µs | -16.45% |
| ❌ | WallTime | bitpack_blocked_compress_avx512 |
4.9 µs | 5.6 µs | -12.84% |
| ❌ ℹ️ | Simulation | test_scan_filter[int] |
3 ms | 3.4 ms | -10.47% |
| ⚡ |
Simulation | random_i128[0.01] |
6 µs | 4.9 µs | +20.35% |
| ⚡ | WallTime | threshold_avx2[80] |
3 µs | 2.7 µs | +12.82% |
| ⚡ ℹ️ | Simulation | test_repeated_scan_scalar_at[int_str_float] |
544.6 µs | 484.3 µs | +12.46% |
| ⚡ |
Simulation | test_repeated_scan_scalar_at[int_float] |
393.1 µs | 357.2 µs | +10.07% |
| ⚡ |
Simulation | test_repeated_scan_scalar_at[int_str] |
442.8 µs | 402.4 µs | +10.04% |
Tip
Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.
Comparing ji/scan-v2-2-driver (da97422) with develop (2274f40)2
Footnotes
-
12 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩
-
No successful run was found on
ji/scan-v2-1-io(7f2d936) during the generation of this report, sodevelop(2274f40) was used instead as the comparison base. There might be some changes unrelated to this pull request in this report. ↩
|
This PR has been marked as stale because it has been open for 14 days with no activity. Please comment or remove the stale label if you wish to keep it active, otherwise it will be closed in 7 days |
|
Closing as superseded: the planning driver is already on Generated by Claude Code |
Summary
2/5 of the V2 scan stack, stacked on #10548. Split out of #10464.
Stack:
vortex-layoutvortex-file, DataFusion and DuckDBChanges
Only
vortex-scanchanges. A planning driver runs planners and morsels on the planning protocol, publishes their IO through anIoServiceand traces their work (vortex_scan::driverdebug events, with the request trace ids from the IO PR). Nothing drives it until the V2 scan PR.Tests: driver unit tests in
planning/driver/tests.rs, plus a scripted planner harness inplanning/tests/scripted.rs.Checks run:
cargo clippy -p vortex-io -p vortex-scan -p vortex-layout -p vortex-file --all-targets --all-features -- -D warningson this commitcargo test -p vortex-scan --lib(on the top of the stack)🤖 Generated with Claude Code
https://claude.ai/code/session_01Hai26WGsNERxRHXpA3JboE
Generated by Claude Code