Repository navigation
Make the list layout opt-in and edition-gated - #10529
Conversation
Signed-off-by: Matt Katz <mhkatz97@gmail.com>
Merging this PR will degrade performance by 14.79%
|
| Mode | Benchmark | BASE |
HEAD |
Efficiency | |
|---|---|---|---|---|---|
| ❌ | WallTime | filter_neon[8] |
869 ns | 1,216 ns | -28.54% |
| ❌ | WallTime | filter_neon[64] |
1.7 µs | 2.3 µs | -23.79% |
| ❌ | WallTime | threshold_neon[80] |
4.2 µs | 5.4 µs | -22.38% |
| ❌ | WallTime | threshold_neon[8] |
1.4 µs | 1.8 µs | -21.52% |
| ❌ ℹ️ | Simulation | test_scan_filter_to_arrow_array[int_float] |
3.5 ms | 4.1 ms | -13.98% |
| ❌ |
Simulation | test_scan_filter[int] |
3.2 ms | 3.7 ms | -13.57% |
| ❌ ℹ️ | Simulation | test_repeated_scan_filter[int_float] |
3.4 ms | 3.9 ms | -11.23% |
| ❌ ℹ️ | Simulation | test_repeated_scan_filter[int] |
2.5 ms | 2.7 ms | -10.4% |
| ⚡ ℹ️ | Simulation | test_repeated_scan_scalar_at[int_float] |
486.7 µs | 403.2 µs | +20.71% |
Tip
Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.
Comparing mk/list-layout-edition-gate (a1bb97f) with develop (18aebea)
## Summary The default writer now writes the list layout whenever the session's enabled editions include `vortex.list`, so the editions are the only switch. `with_list_layout()` is removed, with no opt-out in its place. No default edition includes `vortex.list`, so default writes are unchanged. ## Changes - `WriteStrategyBuilder::from_session` turns the list layout on when the enabled editions include `vortex.list`. - Removes `WriteStrategyBuilder::with_list_layout()`. - vortex-file's test session enables every registered layout, so its list tests now write the list layout; the flat/list switch in `write_read_roundtrip_with_layout` is removed. ## API Changes - Removed `WriteStrategyBuilder::with_list_layout()` (added in #10529, unreleased). --------- Signed-off-by: Matt Katz <mhkatz97@gmail.com>
Summary
Removes the
VORTEX_EXPERIMENTAL_LIST_LAYOUTenvironment variable. The list layout is now written only when a caller opts in withWriteStrategyBuilder::with_list_layout(), and that write fails unless the session's enabled editions include thevortex.listlayout. The environment variable did not work anyway: no default edition includesvortex.list, so setting it made every write fail.Changes
WriteStrategyBuilderno longer reads the environment variable;with_list_layout()is the only way to turn the list layout on.vortex_layout::layouts::table::use_experimental_list_layout.list_layout_is_opt_in_and_edition_gated: opting in on a default session fails the write, and withvortex.listenabled only an opted-in writer emits it.API Changes
use_experimental_list_layout()and theVORTEX_EXPERIMENTAL_LIST_LAYOUTenvironment variable.