Skip to content

Make the list layout opt-in and edition-gated - #10529

Merged
robert3005 merged 2 commits into
developfrom
mk/list-layout-edition-gate
Oct 16, 2026
Merged

robert3005 merged 2 commits into
developfrom
mk/list-layout-edition-gate

Conversation

@mhk197

@mhk197 mhk197 commented Oct 15, 2026

Copy link
Copy Markdown
Contributor

Summary

Removes the VORTEX_EXPERIMENTAL_LIST_LAYOUT environment variable. The list layout is now written only when a caller opts in with WriteStrategyBuilder::with_list_layout(), and that write fails unless the session's enabled editions include the vortex.list layout. The environment variable did not work anyway: no default edition includes vortex.list, so setting it made every write fail.

Changes

  • WriteStrategyBuilder no longer reads the environment variable; with_list_layout() is the only way to turn the list layout on.
  • Removes vortex_layout::layouts::table::use_experimental_list_layout.
  • New test list_layout_is_opt_in_and_edition_gated: opting in on a default session fails the write, and with vortex.list enabled only an opted-in writer emits it.

API Changes

  • Removed use_experimental_list_layout() and the VORTEX_EXPERIMENTAL_LIST_LAYOUT environment variable.

Signed-off-by: Matt Katz <mhkatz97@gmail.com>
@mhk197 mhk197 added the changelog/break A breaking API change label Oct 15, 2026
@mhk197
mhk197 marked this pull request as ready for review October 15, 2026 19:33
@mhk197 mhk197 added changelog/chore A trivial change and removed changelog/break A breaking API change labels Oct 15, 2026
@codspeed

codspeed Bot commented Oct 15, 2026 •

Copy link
Copy Markdown

Merging this PR will degrade performance by 14.79%

⚠️ Unknown Walltime execution environment detected

Using the Walltime instrument on standard Hosted Runners will lead to inconsistent data.

For the most accurate results, we recommend using CodSpeed Macro Runners: bare-metal machines fine-tuned for performance measurement consistency.

⚠️ 25 benchmarks spent significant time in system calls

System calls cannot be consistently instrumented, so they are not included in the measure, which understates the real cost. Please switch to the Walltime instrument to accurately measure system calls.

Measurement and system calls

ℹ️ 40 benchmarks have no flame graph

The flamegraph could not be generated because we failed to resolve the symbols in the profiling trace. This happens when we fail to harvest information about language frames.

⚠️ Different runtime environments detected

Some benchmarks with significant performance changes were compared across different runtime environments,
which may affect the accuracy of the results.

Open the report in CodSpeed to investigate

⚡ 1 improved benchmark
❌ 8 regressed benchmarks
✅ 2250 untouched benchmarks

Warning

Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

Mode Benchmark BASE HEAD Efficiency
❌ WallTime filter_neon[8] 869 ns 1,216 ns -28.54%
❌ WallTime filter_neon[64] 1.7 µs 2.3 µs -23.79%
❌ WallTime threshold_neon[80] 4.2 µs 5.4 µs -22.38%
❌ WallTime threshold_neon[8] 1.4 µs 1.8 µs -21.52%
❌ ℹ️ Simulation test_scan_filter_to_arrow_array[int_float] 3.5 ms 4.1 ms -13.98%
❌ ⚠️ Simulation test_scan_filter[int] 3.2 ms 3.7 ms -13.57%
❌ ℹ️ Simulation test_repeated_scan_filter[int_float] 3.4 ms 3.9 ms -11.23%
❌ ℹ️ Simulation test_repeated_scan_filter[int] 2.5 ms 2.7 ms -10.4%
⚡ ℹ️ Simulation test_repeated_scan_scalar_at[int_float] 486.7 µs 403.2 µs +20.71%

Tip

Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.


Comparing mk/list-layout-edition-gate (a1bb97f) with develop (18aebea)

Open in CodSpeed

Signed-off-by: Matt Katz <mhkatz97@gmail.com>
@robert3005
robert3005 merged commit ad42859 into develop Oct 16, 2026
93 of 94 checks passed
@robert3005
robert3005 deleted the mk/list-layout-edition-gate branch October 16, 2026 11:20
mhk197 added a commit that referenced this pull request Oct 16, 2026
## Summary

The default writer now writes the list layout whenever the session's
enabled editions include `vortex.list`, so the editions are the only
switch. `with_list_layout()` is removed, with no opt-out in its place.
No default edition includes `vortex.list`, so default writes are
unchanged.

## Changes

- `WriteStrategyBuilder::from_session` turns the list layout on when the
enabled editions include `vortex.list`.
- Removes `WriteStrategyBuilder::with_list_layout()`.
- vortex-file's test session enables every registered layout, so its
list tests now write the list layout; the flat/list switch in
`write_read_roundtrip_with_layout` is removed.

## API Changes

- Removed `WriteStrategyBuilder::with_list_layout()` (added in #10529,
unreleased).

---------

Signed-off-by: Matt Katz <mhkatz97@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog/chore A trivial change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants