Skip to content

Benchmark integer statistics with distinct values counted - #10347

Merged
joseph-isaacs merged 1 commit into
developfrom
ji/int-stats-all-bench
Oct 7, 2026
Merged

joseph-isaacs merged 1 commit into
developfrom
ji/int-stats-all-bench

Conversation

@joseph-isaacs

@joseph-isaacs joseph-isaacs commented Oct 6, 2026 •

Copy link
Copy Markdown
Contributor

Summary

#10346 is stacked on this PR. It is independent of #10342, the other bench → impl stack (#10341 → #10342).

The integer_stats CodSpeed benchmarks from #10341 only cover the bounds and the run count. When a dictionary scheme is enabled, the compressor also counts distinct values, so every statistic is computed. This adds that path, so CodSpeed tracks the distinct-counting changes in #10346.

@joseph-isaacs joseph-isaacs added the changelog/skip Do not list PR in the changelog label Oct 6, 2026 — with Claude
@codspeed

codspeed Bot commented Oct 6, 2026 •

Copy link
Copy Markdown

Merging this PR will improve performance by 28.03%

⚠️ Unknown Walltime execution environment detected

Using the Walltime instrument on standard Hosted Runners will lead to inconsistent data.

For the most accurate results, we recommend using CodSpeed Macro Runners: bare-metal machines fine-tuned for performance measurement consistency.

⚠️ Different runtime environments detected

Some benchmarks with significant performance changes were compared across different runtime environments,
which may affect the accuracy of the results.

Open the report in CodSpeed to investigate

⚡ 2 improved benchmarks
✅ 2107 untouched benchmarks
🆕 2 new benchmarks
⏩ 518 skipped benchmarks1

Performance Changes

Mode Benchmark BASE HEAD Efficiency
⚡ Simulation integer_stats_nullable 2.6 ms 1.8 ms +44.76%
⚡ WallTime bitpack_blocked_compress_avx2 7.6 µs 6.7 µs +13.23%
🆕 Simulation integer_stats_all_non_null N/A 1.2 ms N/A
🆕 Simulation integer_stats_all_nullable N/A 2.5 ms N/A

Tip

Curious why performance improved? Comment @codspeedbot explain why performance improved on this PR, or directly use the CodSpeed MCP with your agent.


Comparing ji/int-stats-all-bench (69a3b50) with develop (d9ad4cf)

Open in CodSpeed

Footnotes

  1. 518 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

The integer statistics benchmarks only covered the bounds and the runs.
Add the same non-null and nullable arrays with distinct values counted,
which computes every statistic, as when a dictionary scheme is enabled.

Signed-off-by: Joe Isaacs <joe.isaacs@live.co.uk>

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_018J6qahqrVFb4UCPkwUzY11
@joseph-isaacs
joseph-isaacs force-pushed the ji/int-stats-all-bench branch from 0f5a7bf to 69a3b50 Compare October 6, 2026 20:25
@joseph-isaacs
joseph-isaacs changed the base branch from ji/int-stats-null-words to develop October 6, 2026 20:27
@joseph-isaacs
joseph-isaacs added this pull request to stack #10351 October 7, 2026 09:57
@joseph-isaacs
joseph-isaacs merged commit 5d5f429 into develop Oct 7, 2026
99 of 100 checks passed
@joseph-isaacs
joseph-isaacs deleted the ji/int-stats-all-bench branch October 7, 2026 10:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog/skip Do not list PR in the changelog

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants