Repository navigation
do not merge(scan): planning, physical plans, and plan execution - #10339
Closed
joseph-isaacs wants to merge 7 commits into
Closed
joseph-isaacs wants to merge 7 commits into
joseph-isaacs wants to merge 7 commits into
Conversation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Do not merge. This is the whole V2 scan in one place, for review and benchmarking. It is rebuilt on
develop's push-based pipelines (#10391–#10393): every physical plan now runs on the pipelineScan, and this PR's earlier ExecGraph and PipelineGraph executors are removed.The mergeable pieces are a stack of draft PRs:
Share,Takevalue rules,Evalon encoded predicates, zoned lowering, per-splitValueCache,WholeSource.FileIoService/FileScanIo,read_atchanges, read driver, andget_if_readyon segment caches.ScanBuilder, and DataFusion/DuckDB selection.This branch is those three commits plus one do-not-merge commit holding:
VORTEX_SCAN_V2=1in the test and SQL-benchmark workflows, so the SQL benchmarks here compare V2 againstdevelop's default scanPrevious head: 6115639.
Changes
Scan.ValueCachethat is dropped with the split. Zone tables live for the query. Nothing decoded is kept across scans.Local results on a 4-core VM, DataFusion over Vortex at SF=1, V2/V1 geomean of per-query medians:
No reproducible regressions when the apparent losses were rerun with alternating V1/V2 runs.
🤖 Generated with Claude Code
https://claude.ai/code/session_01P1oQtzTgSzkvrGDKisoNko