Repository navigation
Experiment with retained aggregate states in compression - #10180
connortsui20 wants to merge 1 commit into
Conversation
7b210bd to
7d17dc1
Compare
4412cb4 to
166c0dd
Compare
Merging this PR will degrade performance by 26.58%
|
| Mode | Benchmark | BASE |
HEAD |
Efficiency | |
|---|---|---|---|---|---|
| ❌ | Simulation | bench_compare_varbinview[(10000, 2048)] |
152.6 µs | 207.8 µs | -26.58% |
Tip
Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.
Comparing ct/aggregate-compressor-stats (f9ea7ff) with ct/aggregate-input-owner (34b84b9)
Footnotes
-
503 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩
7d17dc1 to
6de2d57
Compare
166c0dd to
0a3139f
Compare
Signed-off-by: Connor Tsui <connor.tsui20@gmail.com>
6de2d57 to
34b84b9
Compare
0a3139f to
f9ea7ff
Compare
Archived compressor prototype while the experiment is simplified. The original implementation and benchmark evidence remain preserved.
Original PR description
Progress towards #10175
Summary
The compressor already reuses analysis across candidate schemes, but its hardcoded statistics bundles remain separate from aggregate computation. This experiment puts that reuse under an explicit input lifetime while retaining the native maps, sets, and run information used to construct encodings.
Depends on #10179. Promotion of this ownership model remains an open question in the Epic.
Changes
Schemes use bound aggregate requirements and borrowed retained states in place of
ArrayAndStats. Distribution states preserve dictionary preparation and fused run analysis, and samples and derived inputs receive fresh owners.Physical string fingerprints remain representation-specific. Existing floating-point run semantics and encoding heuristics are preserved so the experiment can evaluate ownership without combining semantic changes.
API Changes
Compressor extensions use
ArrayInputand aggregate requirements instead of the legacy statistics bundles. Rich retained states are opt-in and remain separate from finalized file summaries.