Skip to content

Canonical dict execute handles edge cases in Decimal/Bool logic - #10098

Merged
robert3005 merged 1 commit into
developfrom
rk/dictexecute
Oct 8, 2026
Merged

robert3005 merged 1 commit into
developfrom
rk/dictexecute

Conversation

@robert3005

Copy link
Copy Markdown
Contributor

There are edge cases where the downcast would fail

Signed-off-by: Robert Kruszewski <github@robertk.io>
@robert3005 robert3005 added the changelog/fix A bug fix label Sep 28, 2026
@robert3005
robert3005 enabled auto-merge (squash) October 8, 2026 16:13
@robert3005
robert3005 merged commit e0c00d5 into develop Oct 8, 2026
110 of 111 checks passed
@robert3005
robert3005 deleted the rk/dictexecute branch October 8, 2026 16:15
Comment on lines +86 to +88
<Bool as TakeExecute>::take(array, codes_ref, ctx)?
.vortex_expect("take bool should not return None")
.as_::<Bool>()
.into_owned())
.execute::<BoolArray>(ctx)

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this trait used outside of take_canonical?

Should we inline or make a TakeExecute?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog/fix A bug fix

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants