Repository navigation
Canonical dict execute handles edge cases in Decimal/Bool logic - #10098
Merged
Merged
Conversation
Signed-off-by: Robert Kruszewski <github@robertk.io>
robert3005
enabled auto-merge (squash)
October 8, 2026 16:13
joseph-isaacs
approved these changes
Oct 8, 2026
Comment on lines
+86
to
+88
| <Bool as TakeExecute>::take(array, codes_ref, ctx)? | ||
| .vortex_expect("take bool should not return None") | ||
| .as_::<Bool>() | ||
| .into_owned()) | ||
| .execute::<BoolArray>(ctx) |
Contributor
There was a problem hiding this comment.
Is this trait used outside of take_canonical?
Should we inline or make a TakeExecute?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There are edge cases where the downcast would fail