Skip to content

Initialise ArrayParts directly with provided slots - #10072

Merged
robert3005 merged 5 commits into
developfrom
rk/nodrops
Oct 5, 2026
Merged

robert3005 merged 5 commits into
developfrom
rk/nodrops

Conversation

@robert3005

Copy link
Copy Markdown
Contributor

I think this is something that's different between Vec and SmallVec since
smallvec is stack allocated. Confirmed that SmallVec creation and drop survive
in optimised builds.

@robert3005 robert3005 added the changelog/performance A performance improvement label Sep 25, 2026
@codspeed

codspeed Bot commented Sep 25, 2026 •

Copy link
Copy Markdown

Merging this PR will regress 5 benchmarks

⚠️ Unknown Walltime execution environment detected

Using the Walltime instrument on standard Hosted Runners will lead to inconsistent data.

For the most accurate results, we recommend using CodSpeed Macro Runners: bare-metal machines fine-tuned for performance measurement consistency.

⚠️ Different runtime environments detected

Some benchmarks with significant performance changes were compared across different runtime environments,
which may affect the accuracy of the results.

Open the report in CodSpeed to investigate

⚡ 39 improved benchmarks
❌ 5 regressed benchmarks
✅ 2057 untouched benchmarks
⏩ 518 skipped benchmarks1

Warning

Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

Mode Benchmark BASE HEAD Efficiency
❌ Simulation new_raw_prim_test_between[i32, 2048] 67.3 µs 94 µs -28.43%
❌ WallTime mul_u64_nonnull_neon 29.1 µs 40.6 µs -28.25%
❌ Simulation new_bp_prim_test_between[i64, 2048] 78.5 µs 97.1 µs -19.13%
❌ WallTime multiply_shapes_neon[(32768, PerRowPerRow)] 32.9 µs 38.8 µs -15.34%
❌ WallTime mul_i64_nonnull_neon 33 µs 38.9 µs -15.22%
⚡ Simulation compare[1] 135.5 µs 114.2 µs +18.62%
⚡ Simulation new_alp_prim_test_between[f32, 2048] 102.2 µs 86.4 µs +18.22%
⚡ Simulation filter_random_by_power_law[1000] 27.1 µs 24.2 µs +12.34%
⚡ Simulation filter_powerlaw_by_power_law[1000] 27 µs 24.1 µs +12.15%
⚡ Simulation filter_random_by_random[1000] 28 µs 25 µs +11.91%
⚡ Simulation filter_random_by_correlated_runs[1000] 28.2 µs 25.2 µs +11.83%
⚡ Simulation filter_random_by_mostly_true[1000] 28.3 µs 25.3 µs +11.78%
⚡ Simulation filter_all_true[100000] 14.6 µs 13.1 µs +11.75%
⚡ Simulation filter_all_true[10000] 14.6 µs 13.1 µs +11.74%
⚡ Simulation filter_all_true[250000] 14.6 µs 13.1 µs +11.74%
⚡ Simulation filter_powerlaw_by_random[1000] 28 µs 25.1 µs +11.66%
⚡ Simulation filter_powerlaw_by_mostly_true[1000] 28.2 µs 25.2 µs +11.6%
⚡ Simulation filter_random_by_mostly_false[1000] 28.9 µs 25.9 µs +11.51%
⚡ Simulation filter_powerlaw_by_mostly_false[1000] 28.7 µs 25.8 µs +11.34%
⚡ Simulation filter_powerlaw_by_mostly_true[10000] 31.3 µs 28.1 µs +11.18%
... ... ... ... ... ...

ℹ️ Only the first 20 benchmarks are displayed. Go to the app to view all benchmarks.

Tip

Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.


Comparing rk/nodrops (d067deb) with develop (5079a20)

Open in CodSpeed

Footnotes

  1. 518 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

Signed-off-by: Robert Kruszewski <github@robertk.io>
Signed-off-by: Robert Kruszewski <github@robertk.io>
Signed-off-by: Robert Kruszewski <github@robertk.io>
Signed-off-by: Robert Kruszewski <github@robertk.io>
Signed-off-by: Robert Kruszewski <github@robertk.io>
@robert3005
robert3005 enabled auto-merge (squash) October 5, 2026 18:44
@robert3005
robert3005 merged commit c6e51ba into develop Oct 5, 2026
86 of 87 checks passed
@robert3005
robert3005 deleted the rk/nodrops branch October 5, 2026 18:59
rapour added a commit to rapour/vortex that referenced this pull request Oct 16, 2026
`ArrayParts::new` now takes the slots directly (vortex-data#10072), and blocked
bit-packing (vortex-data#10203) replaced `BitPacked::bit_width` with `bit_widths`.
The low-bits width check still applies to a globally packed child, which
is what the encoder writes; a blocked child keeps its widths in an array
rather than metadata, so it is accepted like any other integer child.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Signed-off-by: rapour <reza.apour@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog/performance A performance improvement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants