Repository navigation
bench: Compression Size summary counts l_comment once, leaves out statpopgen, and shows each format's total size - #216
Conversation
…, add Total The Compression Size summary left out only the wide table and sparse-wide datasets. It now also leaves out statpopgen, and it counts the TPC-H l_comment column once: the canonical and chunked files are the same size. The compression time summary keeps both datasets. Each format now shows Total, the sum of its file sizes over the same datasets. The header names the unit once. The vs Parquet column "Mean" is now "GeoMean". Phones hide Min and Max to make room for Total; the screen-reader text still gives them. The group payload cache moves to v12, because the summary shape changed. Signed-off-by: Will Manning <will@willmanning.io>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 8b232dd616
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
🔦 Lighthouse audit
Run |
Lance and Arrow IPC come from their own snapshots, so a format can lack a dataset that the others have. Its Total then summed fewer files and looked smaller. Each Total now sums only the datasets that every ranked format has, and shows a dash when the formats share none. Both size queries now return the dataset key. Signed-off-by: Will Manning <will@willmanning.io>
What changes
On bench, the Compression Size summary no longer counts statpopgen. It also counts the TPC-H
l_commentcolumn once, because its canonical and chunked files are the same size. The compression time summary still includes both datasets, and both still have charts.Each format now shows Total, the sum of its file sizes over the same datasets. The header shows the unit once. The "Mean" column is now "GeoMean". On phones, the card hides Min and Max so that Total fits. The methodology page lists the excluded datasets.
How it was checked
bun run check:ci, the typecheck, knip, the build, and both sites' tests pass. I rendered the card with the built CSS and today's sizes. No local database was available.After, at 375 px:
git commit -s), for the DCO check.bun run check:cipasses.REUSE.toml. (No new assets.)🤖 Generated with Claude Code