Skip to content

Show the same header, footer, 404, and theme switch on the site and bench - #194

Merged
lwwmanning merged 17 commits into
mainfrom
wm/one-site
Nov 4, 2026
Merged

lwwmanning merged 17 commits into
mainfrom
wm/one-site

Conversation

@lwwmanning

@lwwmanning lwwmanning commented Nov 4, 2026 •

Copy link
Copy Markdown
Contributor

This change gives the site and bench the same chrome as the docs and the Explorer.

  • All pages show one header: the wordmark, Docs, Bench, Explorer, Blog, and Slack, the theme switch, and the GitHub button. On a phone, the Menu holds the links, the switch, and GitHub.
  • All pages show one footer. On a wide screen, its text uses two lines.
  • The 404 shows the mark over a dot field.
  • The theme is Dark by default, also when the OS uses Light. A cookie on .vortex.dev keeps the choice on all subdomains. A choice saved on bench before this change stays. The home page follows the theme.
  • In Light, the mark's pointer trail uses two blues, as in Dark.

Lint, typecheck, knip, unit, bench, verify, and Playwright tests pass locally.

Screenshots

Before is production. After is a local production build. The bench "after" uses local test data, so its numbers differ.

Home

Dark, 1440px

Home, dark, 1440px

Dark, 390px

Home, dark, 390px

Light, 1440px

Home, light, 1440px

Light, 390px

Home, light, 390px

Home footer

Dark, 1440px

Home footer, dark, 1440px

Light, 1440px

Home footer, light, 1440px

Blog

Dark, 1440px

Blog, dark, 1440px

Dark, 390px

Blog, dark, 390px

Light, 1440px

Blog, light, 1440px

Light, 390px

Blog, light, 390px

Post

Dark, 1440px

Post, dark, 1440px

Dark, 390px

Post, dark, 390px

Light, 1440px

Post, light, 1440px

Light, 390px

Post, light, 390px

Bench

Dark, 1440px

Bench, dark, 1440px

Dark, 390px

Bench, dark, 390px

Light, 1440px

Bench, light, 1440px

Light, 390px

Bench, light, 390px

404

Dark, 1440px

404, dark, 1440px

Dark, 390px

404, dark, 390px

Light, 1440px

404, light, 1440px

Light, 390px

404, light, 390px

🤖 Generated with Claude Code

Signed-off-by: Will Manning <will@willmanning.io>
Every surface draws the same header (links, then the theme switch and the
GitHub button), with bench's controls in the tools slot between them. The
home page gets the switch too, System is the default, and the choice is
shared through a vx-theme cookie on vortex.dev. bench drops its own theme
toggle and favicon pair and renders the site's footer and 404.

Signed-off-by: Will Manning <will@willmanning.io>
Only the blog follows the theme on the site; the home page and every 404
stay Dark whatever the reader chose, through a data-theme-lock on the root
that holds across client-side navigation. bench's page frame takes the
site's 1440px column, its header buttons drop their words below 1440px so
they fit beside the switch and the GitHub button, and its 404 takes the
site's title.

Signed-off-by: Will Manning <will@willmanning.io>
The Light colours get softer instead, so these pages need not stay Dark.

Signed-off-by: Will Manning <will@willmanning.io>
The design system's new DotField draws the ASCII mark's field of dots,
still, behind the 404, the blog index, and around a post's card, fading
toward the sides and the foot. On the 404 the mark leaves its own dots to
it, so the page shows one grid. A phone, where a post has no card, drops
the field behind the post.

Signed-off-by: Will Manning <will@willmanning.io>
…xt column

Signed-off-by: Will Manning <will@willmanning.io>
Signed-off-by: Will Manning <will@willmanning.io>
Signed-off-by: Will Manning <will@willmanning.io>
Signed-off-by: Will Manning <will@willmanning.io>
Signed-off-by: Will Manning <will@willmanning.io>
Signed-off-by: Will Manning <will@willmanning.io>
Signed-off-by: Will Manning <will@willmanning.io>
The shared header has no top margin, so the hero takes the screen less
64px, not 80px. The smoke tests now expect what DECISIONS 37 set:
System by default, the switch on the homepage, and the Menu's twin
rows on a phone.

Signed-off-by: Will Manning <will@willmanning.io>
@vercel

vercel Bot commented Nov 4, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
vortex.dev Ready Ready Preview Nov 4, 2026 10:59pm UTC

Request Review

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 4, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-04T23:02:27.826993Z a24742e New commits
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@github-actions

github-actions Bot commented Nov 4, 2026 •

Copy link
Copy Markdown

🔦 Lighthouse audit

URL Perf A11y Best practices SEO
/ 🟢 100 🟢 100 🟢 100 🟢 100
/bench 🟢 100 🟢 100 🟢 100 🟢 100
/bench/chart/ct.eyJrIjoiQ29tcHJlc3Npb25UaW1lIiwiZGF0YXNldCI6ImFyYWRlIiwiZGF0YXNldF92YXJpYW50IjpudWxsfQ 🟢 100 🟢 100 🟢 100 🟢 100
/blog 🟢 100 🟢 100 🟢 100 🟢 100
/blog/btrblocks-compressor 🟢 100 🟢 100 🟢 100 🟢 100

Run 41929968112 · 2026-11-04 23:01 UTC

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 3270a8fc74

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread src/lib/theme.ts Resolved
bench saved the reader's Light or Dark choice under
localStorage["bench-theme"]. The first-paint scripts now move it to
vx-theme, unless the reader already chose there, and remove the old key.

Signed-off-by: Will Manning <will@willmanning.io>
The shared cookie still wins, then this origin's storage. Without either,
the theme is Dark, whatever the OS prefers, and the server renders
data-theme="dark" for readers without scripts. System stays a choice.

Signed-off-by: Will Manning <will@willmanning.io>

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 979559e408

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread src/vendor/vortex-design/theme.js Resolved
Comment thread src/lib/theme.ts Resolved
…ld choice when storage is full

A choice saved before the shared cookie existed lives only in one origin's
storage. The first paint now copies it into the vx-theme cookie, so bench,
the docs, and the Explorer see it too.

The design system's bootstrap now takes bench's old key, bench-theme, as a
legacy key. A valid value there paints the page even when storage refuses
to copy it to vx-theme.

Signed-off-by: Will Manning <will@willmanning.io>
@lwwmanning

Copy link
Copy Markdown
Contributor Author

@codex please review

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 5eec3bd3ea

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread src/vendor/vortex-design/theme.js Resolved
Comment thread src/app/(bench)/bench/not-found.tsx Resolved
bench's header adds a hidden "Benchmarks" h1 on every page. On the 404 the
code is the page's h1, so the header now leaves its own out there.

Signed-off-by: Will Manning <will@willmanning.io>
@lwwmanning
lwwmanning merged commit cf7ef3b into main Nov 4, 2026
24 checks passed
@lwwmanning
lwwmanning deleted the wm/one-site branch November 4, 2026 23:07

This branch was successfully deployed

1 active deployment
Preview — a24742e2 Deployed Nov 4, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant