Repository navigation
Conversation
GNU grep -E accepts PCRE syntax such as (?i), (?:...) and lookarounds that git grep -E rejects, so a secret pattern using it passed validation and then failed the scan as an opaque 'git grep failed'. Validate denylist patterns with git grep itself so the error names the pattern index and never prints the pattern. Allowlist patterns keep GNU grep validation because grep applies them.
bntvllnt
added a commit
that referenced
this pull request
Oct 30, 2026
….8 (#25) ## Authorized sensitive baseline update The repo owner asked for the stack pin to follow the skills package-owner answers (vllnt/skills#28). Accept source `7483dd4dfd8502fd2db376c13e44fa0cbc464161` through this separate protected PR, as in #9 and #23, without changing the automatic sensitivity policy. - Pin moves from `352eaf7b167a6761161415711ef9d55db26d91d6` (1 skills commit). - Bump distribution `0.1.0-canary.7` to `0.1.0-canary.8`. - Regenerate all three hosts with `scripts/sync.py`; no generated file was edited by hand. - Content: `@vllnt/convex-api-keys`, `@vllnt/logger`, `@vllnt/analytics` defaults; `ui-core`/`ui-native` experimental opt-in; `dig` not yet default. - No updater, generator, workflow, permission or branch-protection changes. ## Verification - 38 unit tests pass; `sync.py --check` matches all 551 files both offline and over the public network; `git diff --check` passes; gitleaks over full history finds nothing. - Only `upstream.lock.json`, `VERSION`, `CHANGELOG.md` and generated `plugins/**` change. - Privacy Guard is red on this PR for the same reason it is red on `main`: the `PRIVACY_DENYLIST_EXTRA` secret has patterns `git grep -E` rejects (see #24). It fails before scanning content.
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Since
PRIVACY_DENYLIST_EXTRAwas set, Privacy Guard fails on every run, including unchangedmain, witherror: git grep failed(exit 2). The guard validated patterns with GNUgrep -Ebut scans withgit grep -E. They disagree on PCRE syntax:(?i),(?:...), lookarounds and\p{..}compile under GNU grep and are fatal in git grep. A secret pattern using one passed validation and then killed the scan with no hint which line.This validates denylist patterns with
git grep -E, so the failure names the pattern by index (denylist pattern #N is not a valid regex) and never prints the pattern. Still fail-closed; nothing is loosened.Scope
scripts/privacy-denylist.sh: engine-matched validation (allowlist patterns stay on GNU grep, which applies them).scripts/test-privacy-denylist.sh: 4 regression cases (RED before: exit 2 but opaque message; GREEN after).CHANGELOG.md.This PR does NOT include
(?i): the scan is already case-insensitive).Test plan
bash scripts/test-privacy-denylist.sh: 36 cases pass.bash scripts/privacy-denylist.sh: clean on this tree.