Skip to content

test: unblock r7 (plugin Retry-After floor, heartbeat flake, vet) - #11

Merged
bntvllnt merged 1 commit into
mainfrom
fix/r7-test-blockers
Nov 14, 2026
Merged

bntvllnt merged 1 commit into
mainfrom
fix/r7-test-blockers

Conversation

@bntvllnt

@bntvllnt bntvllnt commented Nov 14, 2026 •

Copy link
Copy Markdown

Blocks the r7 release: TestPluginErrorCarriesRetryAfterIntoCooldownAndHTTPHeader failed every run (want 7, got 10).

Cause: the test (upstream 14e5771, 9 Nov) ignores the 10s quota cooldown floor added upstream in 18e01a7 (3 Sep), which r6 already ships. The direct plugin error still carries 7; after the manager records the cooldown, the floor (10) governs Retry-After. Test now asserts that.

Also:

  • TestServiceHeartbeatFailoverDoesNotDrainBlockingScope: positive waits 1s -> 10s (4/60 flakes under load). Negative 50ms checks unchanged.
  • go vet copied-lock warning at internal/pluginhost/host_test.go:1637: removed the unused sync.Once.

Tests only, no production code.

Verification: the Retry-After test passed 200/200; -race on pluginhost passed; the heartbeat test passed 60/60, plus 120 more at -cpu 1,2 under parallel load; go vet on both packages is clean; the build is clean. The full suite has only the host-local mDNS TestAdvertiserAndBrowser_Integration failure, which the infra build does not hit.

…tbeat flake

- pluginhost: the manager applies its 10s quota cooldown floor (18e01a7) to a
  plugin's 7s Retry-After, so the client-visible header is 10.
- sdk/cliproxy: give the positive waits in the heartbeat failover test 10s
  instead of 1s; it flaked under host load. Negative 50ms checks unchanged.
- pluginhost: drop an unused sync.Once that go vet flagged as a copied lock.
@bntvllnt
bntvllnt merged commit 4a1c9b8 into main Nov 14, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant