Repository navigation
test: unblock r7 (plugin Retry-After floor, heartbeat flake, vet) - #11
Merged
Merged
Conversation
…tbeat flake - pluginhost: the manager applies its 10s quota cooldown floor (18e01a7) to a plugin's 7s Retry-After, so the client-visible header is 10. - sdk/cliproxy: give the positive waits in the heartbeat failover test 10s instead of 1s; it flaked under host load. Negative 50ms checks unchanged. - pluginhost: drop an unused sync.Once that go vet flagged as a copied lock.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Blocks the r7 release:
TestPluginErrorCarriesRetryAfterIntoCooldownAndHTTPHeaderfailed every run (want 7, got 10).Cause: the test (upstream 14e5771, 9 Nov) ignores the 10s quota cooldown floor added upstream in 18e01a7 (3 Sep), which r6 already ships. The direct plugin error still carries 7; after the manager records the cooldown, the floor (10) governs Retry-After. Test now asserts that.
Also:
TestServiceHeartbeatFailoverDoesNotDrainBlockingScope: positive waits 1s -> 10s (4/60 flakes under load). Negative 50ms checks unchanged.go vetcopied-lock warning atinternal/pluginhost/host_test.go:1637: removed the unusedsync.Once.Tests only, no production code.
Verification: the Retry-After test passed 200/200;
-raceon pluginhost passed; the heartbeat test passed 60/60, plus 120 more at-cpu 1,2under parallel load;go veton both packages is clean; the build is clean. The full suite has only the host-local mDNSTestAdvertiserAndBrowser_Integrationfailure, which the infra build does not hit.