Repository navigation
Differential updates: patch a VIM with a partial export (object model 5.8.0, VimPatchService) - #65
Open
SamuelAB-VIM wants to merge 1 commit into
Open
SamuelAB-VIM wants to merge 1 commit into
SamuelAB-VIM wants to merge 1 commit into
Conversation
…ice, export fingerprint header values) - WIP, Fable audit pass, not reviewed Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Companion to the exporter PR in vimaec/vimaec https://github.com/vimaec/vimaec/pull/1182. The two merge together: the exporter's submodule pointer already points here.
What this adds:
Element.ChangeToken(Revit's VersionGuid) andBimDocument.Identity, so a VIM knows what each element looked like when it was exported.Vim.Format.Merge.VimPatchService: patches a partial VIM into an existing one on raw tables (no DocumentModel). Changed elements are replaced in place, new ones appended, deleted ones removed, every relation re-pointed, geometry kept aligned.SerializableHeader.CreateRevisionOfand aDocumentBuilderconstructor taking a header, so a patched file keeps its Id with a new revision.Tests:
Vim.Format.Tests64 passed, 2 skipped, 0 failed (2 newVimPatchServiceTests); TS tests 11 passed.Proof on TowerS (52,657 elements, Revit 2027): a differential update compared element by element with a full export of the same edited state gives 0 of 52,652 differing, and its file passes
VimScene.Validate. Full details, files and limits are in the exporter PR.Note: 5.8.0 may collide with other unmerged vim-format branches; renumber at merge if needed.
🤖 Generated with Claude Code