Skip to content
This repository was archived by the owner on Jan 6, 2026. It is now read-only.

Added C++14 binary literal highlight - #31

Merged
mattn merged 1 commit into
vim-jp:masterfrom
rhysd:cpp14
Sep 23, 2015
Merged

mattn merged 1 commit into
vim-jp:masterfrom
rhysd:cpp14

Conversation

@rhysd

@rhysd rhysd commented Feb 28, 2015

Copy link
Copy Markdown
Contributor

ISO/IEC 14882:2014 was issued at the beginning of this year. So we should start to improve vim-cpp to work well with C++14 code, I think.

As a first work, I added g:cpp_no_cpp14 variable check and a highlight for binary literal.

int main()
{
    0b01010100010;
    0b01010100010ll;
    0b01010100010ul;

    return 0;
}

@mattn

mattn commented Feb 28, 2015

Copy link
Copy Markdown
Member

LGTM but leave to others.

@rhysd

rhysd commented Feb 28, 2015

Copy link
Copy Markdown
Contributor Author

@mattn

Thank you for your review.

Can anyone else review this PR?

@mattn

mattn commented Mar 2, 2015

Copy link
Copy Markdown
Member
"\<0b[01]\+\(u\=l\{0,2}\|ll\=u\)\>"

でなくて大丈夫ですかね?

@rhysd

rhysd commented Mar 2, 2015

Copy link
Copy Markdown
Contributor Author
"\<0b[01]\+\(u\=l\{0,2}\|ll\=u\)\>"

でなくて大丈夫ですかね?

必要でした.ありがとうございます.今夜修正します.

@rhysd

rhysd commented Mar 2, 2015

Copy link
Copy Markdown
Contributor Author

@mattn

修正しました!

@rburny

rburny commented Sep 22, 2015

Copy link
Copy Markdown
Contributor

Hello,
could you please merge this pull request? Or alternatively, would it make sense to expand cppNumber definition to also cover digit separators?

@rhysd

rhysd commented Sep 23, 2015

Copy link
Copy Markdown
Contributor Author

@rburny

Hi, could you review this PR?
This PR is not merged yet because of lack of reviewer.

mattn added a commit that referenced this pull request Sep 23, 2015
Added C++14 binary literal highlight
@mattn
mattn merged commit 5132f6d into vim-jp:master Sep 23, 2015
@mattn

mattn commented Sep 23, 2015

Copy link
Copy Markdown
Member

@rhysd 👍

@mattn

mattn commented Sep 23, 2015

Copy link
Copy Markdown
Member

I'll send latest syntax/cpp.vim to vim-dev

@rburny

rburny commented Sep 23, 2015

Copy link
Copy Markdown
Contributor

Thanks!
This one's already handled, but if you need review in future, feel free to ping me.

@rhysd

rhysd commented Sep 24, 2015

Copy link
Copy Markdown
Contributor Author

@mattn

I'll send latest syntax/cpp.vim to vim-dev

🐶👍

@rburny

This one's already handled, but if you need review in future, feel free to ping me.

Thank you for your help!
When I implement additional support, I may ping you.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants