Wrong C++ highlighting #41

Activity

1. mattn commented on Aug 29, 2016

   

   mattn

   on Aug 29, 2016

   MemberAuthor

   More actions

   I'm not sure, but removing ^ fixes this syntax.

   diff --git a/syntax/c.vim b/syntax/c.vim
   index 85042e4..b7dedb3 100644
   --- a/syntax/c.vim
   +++ b/syntax/c.vim
   @@ -388,11 +388,11 @@ if !exists("c_no_if0")
    endif
    syn region cIncluded   display contained start=+"+ skip=+\\\\\|\\"+ end=+"+
    syn match  cIncluded   display contained "<[^>]*>"
   -syn match  cInclude    display "^\s*\(%:\|#\)\s*include\>\s*["<]" contains=cIncluded
   +syn match  cInclude    display "\s*\(%:\|#\)\s*include\>\s*["<]" contains=cIncluded
    "syn match cLineSkip   "\\$"
    syn cluster    cPreProcGroup   contains=cPreCondit,cIncluded,cInclude,cDefine,cErrInParen,cErrInBracket,cUserLabel,cSpecial,cOctalZero,cCppOutWrapper,cCppInWrapper,@cCppOutInGroup,cFormat,cNumber,cFloat,cOctal,cOctalError,cNumbersCom,cString,cCommentSkip,cCommentString,cComment2String,@cCommentGroup,cCommentStartError,cParen,cBracket,cMulti,cBadBlock
   -syn region cDefine     start="^\s*\(%:\|#\)\s*\(define\|undef\)\>" skip="\\$" end="$" keepend contains=ALLBUT,@cPreProcGroup,@Spell
   -syn region cPreProc    start="^\s*\(%:\|#\)\s*\(pragma\>\|line\>\|warning\>\|warn\>\|error\>\)" skip="\\$" end="$" keepend contains=ALLBUT,@cPreProcGroup,@Spell
   +syn region cDefine     start="\s*\(%:\|#\)\s*\(define\|undef\)\>" skip="\\$" end="$" keepend contains=ALLBUT,@cPreProcGroup,@Spell
   +syn region cPreProc    start="\s*\(%:\|#\)\s*\(pragma\>\|line\>\|warning\>\|warn\>\|error\>\)" skip="\\$" end="$" keepend contains=ALLBUT,@cPreProcGroup,@Spell
   
    " Highlight User Labels
    syn cluster    cMultiGroup contains=cIncluded,cSpecial,cCommentSkip,cCommentString,cComment2String,@cCommentGroup,cCommentStartError,cUserCont,cUserLabel,cBitField,cOctalZero,cCppOutWrapper,cCppInWrapper,@cCppOutInGroup,cFormat,cNumber,cFloat,cOctal,cOctalError,cNumbersCom,cCppParen,cCppBracket,cCppString
2. rhysd commented on Sep 1, 2016

   

   rhysd

   on Sep 1, 2016

   Contributor

   More actions

   I think \s* at the head of pattern should be removed as well.
3. mattn commented on Sep 1, 2016

   

   mattn

   on Sep 1, 2016

   MemberAuthor

   More actions

   right
4. mattn

   closed this as completedin 8976decon Oct 28, 2016
5. brammool commented on Nov 17, 2016

   

   brammool

   on Nov 17, 2016

   More actions

   Since when is putting a comment before #if valid C?
6. mattn commented on Nov 18, 2016

   

   mattn

   on Nov 18, 2016

   Last edited by mattn

   MemberAuthor

   More actions

   @brammool This should fix it.

   8976dec

   diff --git a/syntax/c.vim b/syntax/c.vim
   index cc99f67..82148e7 100644
   --- a/syntax/c.vim
   +++ b/syntax/c.vim
   @@ -358,8 +358,8 @@ if !exists("c_no_c99") " ISO C99
    endif
   
    " Accept %: for # (C99)
   -syn region cPreCondit  start="^\s*\zs\(%:\|#\)\s*\(if\|ifdef\|ifndef\|elif\)\>" skip="\\$" end="$" keepend contains=cComment,cCommentL,cCppString,cCharacter,cCppParen,cParenError,cNumbers,cCommentError,cSpaceError
   -syn match  cPreConditMatch display "^\s*\zs\(%:\|#\)\s*\(else\|endif\)\>"
   +syn region cPreCondit  start="\s*\zs\(%:\|#\)\s*\(if\|ifdef\|ifndef\|elif\)\>" skip="\\$" end="$" keepend contains=cComment,cCommentL,cCppString,cCharacter,cCppParen,cParenError,cNumbers,cCommentError,cSpaceError
   +syn match  cPreConditMatch display "\s*\zs\(%:\|#\)\s*\(else\|endif\)\>"
    if !exists("c_no_if0")
      syn cluster  cCppOutInGroup  contains=cCppInIf,cCppInElse,cCppInElse2,cCppOutIf,cCppOutIf2,cCppOutElse,cCppInSkip,cCppOutSkip
      syn region   cCppOutWrapper  start="^\s*\zs\(%:\|#\)\s*if\s\+0\+\s*\($\|//\|/\*\|&\)" end=".\@=\|$" contains=cCppOutIf,cCppOutElse,@NoSpell fold
7. mattn commented on Nov 18, 2016

   

   mattn

   on Nov 18, 2016

   MemberAuthor

   More actions

   @brammool or, do you ask me why need this change?
8. mattn commented on Nov 18, 2016

   

   mattn

   on Nov 18, 2016

   Last edited by mattn

   MemberAuthor

   More actions

   @brammool Ah, I understanded it just now. vim/vim#1257 (comment)
9. mattn commented on Apr 26, 2017

   

   mattn

   on Apr 26, 2017

   MemberAuthor

   More actions

   I rebased this repository. And reverted 8976dec

   So this issue still are remaining.
10. mattn

    reopened this on Apr 26, 2017
12. brammool commented on May 15, 2017

    

    brammool

    on May 15, 2017 via email

    More actions

    Robot wrote:

    @brammool: This was likely always valid C/C++, you can check yourself with `gcc` or `g++`. The requirement seems to be the line needs to be devoid of statements before the preprocessor directive. ```C++ (void)0; #ifdef POSIX #endif ``` ``` error: stray # in program (void)0; #ifdef POSIX ^ ``` and an ensuing error about the mismatched `#endif`.

    Vim doesn't see the #ifdef as preproc, thus I would think that is OK. Highlighting it as an error doesn't seem useful. It would cause a lot of flickering while typing.

    …

    -- ERIC IDLE PLAYED: THE DEAD COLLECTOR, MR BINT (A VILLAGE NE'ER-DO -WELL VERY KEEN ON BURNING WITCHES), SIR ROBIN, THE GUARD WHO DOESN'T HICOUGH BUT TRIES TO GET THINGS STRAIGHT, CONCORDE (SIR LAUNCELOT'S TRUSTY STEED), ROGER THE SHRUBBER (A SHRUBBER), BROTHER MAYNARD "Monty Python and the Holy Grail" PYTHON (MONTY) PICTURES LTD /// Bram Moolenaar -- Bram@Moolenaar.net -- http://www.Moolenaar.net \\\ /// sponsor Vim, vote for features -- http://www.Vim.org/sponsor/ \\\ \\\ an exciting new programming language -- http://www.Zimbu.org /// \\\ help me help AIDS victims -- http://ICCF-Holland.org ///
14. brammool commented on May 16, 2017

    

    brammool

    on May 16, 2017 via email

    More actions

    @brammool: That was a counterexample, the bug was about this case: ```C++ /**/ #ifdef POSIX #endif ``` Which isn't highlighted properly by Vim (or GitHub), despite being valid C/C++. There may be any amount of whitespace before a preprocessor directive on a line and comments seem to count as part of this whitespace.

    I'm quite sure older C standards do not allow this. I would never write it like this anyway. Currently we recognize the # at the start of the line. Allowing a comment before it isn't that easy. Properly detecting /* */ comments is difficult anyway. I think we can just leave this out.

    …

    -- (letter from Mark to Mike, about the film's probable certificate) For an 'A' we would have to: Lose as many shits as possible; Take Jesus Christ out, if possible; Loose "I fart in your general direction"; Lose "the oral sex"; Lose "oh, fuck off"; Lose "We make castanets out of your testicles" "Monty Python and the Holy Grail" PYTHON (MONTY) PICTURES LTD /// Bram Moolenaar -- Bram@Moolenaar.net -- http://www.Moolenaar.net \\\ /// sponsor Vim, vote for features -- http://www.Vim.org/sponsor/ \\\ \\\ an exciting new programming language -- http://www.Zimbu.org /// \\\ help me help AIDS victims -- http://ICCF-Holland.org ///

    👍React with 👍1Reacted by David Briscoe
16. mattn commented on May 17, 2017

    

    mattn

    on May 17, 2017

    MemberAuthor

    More actions

    To fix this, it need the regexp pattern enough to be confusable. And it will take heavy load.