Repository navigation
Phase 31 slice D: desktop-app realisations and their gate - #248
Merged
Merged
Conversation
Six desktop-app page realisations (split-workbench, list-detail, editor-inspector, browser, dashboard, settings) plus data-table-app and skeleton-table-app, gated in fast and detailed mode, under stress and at 1024px. Scrolling frames read as scrolling under stress, app rows and card grids are tripled on desktop-app, and a property-row's label names its control.
Realisations stay clean at 1280 and 1024 wide and with data-table stamped into a pane, a blank property-row label falls back to text in the row, and the gate gains twins for its predicates and the values it never pinned.
Its search sits in a shrinkable slot and the row count truncates, and the window gate stamps the table into each pane at 1440, 1100 and 1024 wide.
Linux fonts wrap its column names in list-detail's 422px detail pane at 1024 wide, so the header outgrew its rows. The window gate stamps the table only into panes at least 480px wide and pins the one pane it skips.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Slice D of Phase 31 (docs/specs/PHASE-31-SPEC.md, FR-D1 to FR-D3): starting points for application screens. On a
desktop-appcanvas,apply_structurenow stamps a desktop-app layout built from the app primitives, held to a stricter gate than the web and mobile sets. The spec's "Slice D — contracts pinned before build" block records what the gate covers and four spec changes (S4 to S7); the "Slice D — as built" block records every decision the spec left open.What changes
split-workbench-app: a header with a pane toggle, a work area and a detail panel.list-detail-app: a searchable list and a detail pane with a designed "nothing selected" placeholder.editor-inspector-app: a work area with a tool strip beside a 70/30 inspector of tabs and property rows.browser-app: a filter bar over an adaptive grid of item cards whose titles are links.dashboard-app: stat tiles, a trend chart and a table.settings-app: grouped property rows, a danger zone and Cancel / Save.list-detail,editor-inspectorandbrowserexist only on desktop-app; on a web or phone canvas they are refused with the parameter that forces them.data-table-appkeeps its toolbar, header, rows and pager at 32px, andskeleton-table-appis its loading state. On a desktop-app canvas,data-tableandskeleton-tableresolve to them, and the coverage hint for a missing loading state namesskeleton-table-app.overflowto"hidden", which keeps the root at the window's height so long content scrolls inside its pane. A later page stamp withreplaceremoves it again, unless the author changed it.overflow: "auto"is now treated like a sheet panel: its vertical overflow is scrolling, not a clip. Its horizontal overflow still clips.manyandemptyalso act on runs of nav-items, tree rows, menu rows and property rows, and on card grids. Before, they touched nothing on an app screen, so it passed by default. A tripled list keeps one active row.property-row's label names its control. The "control has no text label" warning ignored the row'slabel, so every inspector toggle warned. With a blank label, only text inside the row itself counts, never a neighbouring row's text. This applies on every type.$accent-tint. Presets carry no tint, so a dark seed survived a later light preset and drew the active nav-item as a dark chip on a light page. Without the token, the renderer mixes the accent into whatever surface is applied.apply_structure,list_structures,canvas_create,canvas_stressandbatch_designdocstringsdocs/GUIDELINES.md: a new "Starting an application screen" section with what each stamp's coverage asks forDecisions worth a look
canvas_evaluatesays it is ready right after a stamp, unless coverage asks for a state variant. The web patterns already meet that bar. The inputs are the ones the docs promise an agent:apply_presetdoesdata-tablestamped into each realisation's wide pane at three widthsoverflow: "auto"that overflows vertically used to be a stress warning on web. It now reads as scrolling, which is correct, but a static screenshot still shows it cut off. No web or mobile scaffold usesoverflow: "auto", and the importer never produces it.src/structure-tokens.ts, so the desktop-app structures live in their own file without an import cycle. The values are unchanged.property-rowwhose control sits inside a wrapper frame still warns. This predates the slice and happens on every type.data-table-appstamped into a 300px side panel or the inspector clips. The description and the docs say to put it in a wide pane.Testing
test-patterns.ts(fast): the desktop-app gate. That is 8 structures × 18 inputs, each structure's coverage asks pinned, and twins that must fail on each part of the pass rule:test-patterns-desktop.ts(Chrome) covers detailed mode and stress under every personality. After tripling, the root keeps its height, no row squashes, and content tripled twice scrolls inside a pane. It also checks the 1024×768 stamp. Twins cover a pane withoverflow: "hidden", a root without theoverflowprop, and a table that clips.test-patterns-desktop-window.ts(Chrome) covers stress at 1024 and 1280 wide anddata-tablein every wide pane.test-desktop-structures.ts(fast) covers the stress runs with their twins, the property-row label cases and the coverage hint.test-structures.ts: resolution on three types, root props, and the values the realisations must keep (pane width floors, 32px rows, the 240px grid minimum)test-structures-mcp.ts: listing and stamping through the MCP handlerstest-scaffold-system.ts,test-discoverability.tsandtest-desktop-primitives.tsapply_preset. All 12 were folded into the spec before the build.