Repository navigation
Add the desktop-app rules (Phase 31 slice C) - #247
Merged
Merged
Conversation
Phase 31 slice C (FR-C1..C10): eight desktop-app-* rule ids for targets, hand-built targets, icon names, wayfinding, the dense type ladder, row rhythm, truncation and primary count, plus text-inputs in the form coverage demand. Spec change S2 widens FR-C2 to bordered text buttons.
Select-all headers stay headers, fast estimates honour min sizes and stacked captions, fluid link widths stay unknown, primaries are what renders filled, the ladder reads string sizes, and findings fold. Spec change S3: link renders ariaLabel and FR-C3 checks icon-only links.
A first row holding a control is a header only when its text is styled apart from the next row. The stacked icon-and-caption estimate needs both as in-flow children; auto, null and px link widths are measured again.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Slice C of Phase 31 (docs/specs/PHASE-31-SPEC.md, FR-C1 to FR-C10): the rules that judge a
desktop-appcanvas as an application. The spec's "Slice C — as built" block records every decision the spec left open and two spec changes, S2 and S3, both approved before they were built.What changes
surfacereport lists them inrulesOnon desktop-app canvases only:desktop-app-target: the existing 24px click-target floor under a rule id. It warns in fast mode and is an error in detailed mode when the target's 24px circle reaches a neighbour.desktop-app-handbuilt-target(info, never blocks): a frame below 32px shaped like a button is named, with the primitive to rebuild it as. The shapes are an icon, an icon with a label of up to three words, or a bordered, padded frame holding one short label.desktop-app-icon-label: an icon-only button or link with noariaLabelwarns, and so does a collapsed nav-item with no label.desktop-app-current: checks that the current location is unambiguous.overflow: "auto", or the root.desktop-app-type-ladder: replaces the adjacent-ratio check on desktop-app.desktop-app-row-rhythm: applies to tables.desktop-app-truncation: a truncating column header warns, and an ellipsis with notitleis an info. Detailed mode adds two more:desktop-app-primary-count(info): two or more primary buttons in one pane. Primaries inside a grid of three or more same-shaped cards don't count.text-inputs. A form of three or more input controls asks for anerrorvariant, now with text inputs counted, on every type. Drift's control list is unchanged.linkis measured at its glyphs (14px wide, or 30 with the external glyph) instead of being treated as unknown width. This applies on web too.linkrendersariaLabelasaria-labelandtitle, likebutton(spec change S3).snapshot_layoutdocuments the field.canvas_evaluate,snapshot_layoutandbatch_designdocstringsdocs/GUIDELINES.md(a section per rule, with what a pane and prose mean)Decisions worth a look
errorvariant, as three toggles already did.Testing
test-desktop-app-rules.ts(fast tier), 140+ checks:test-desktop-app-rules-detailed.ts(Chrome tier):test-desktop-app.ts:rulesOnlists every desktop-app rule."auto",nulland"10px"were no longer measured.npm run test:fullpasses 125/125 on f145107.npm run test:fastpasses 85/85 on the final commit 6f16160, which only rewords three comments.