Skip to content

Fix typescript typings - #648

Merged
ibc merged 2 commits into
versatica:masterfrom
phwb:typings-fix
Nov 5, 2022
Merged

ibc merged 2 commits into
versatica:masterfrom
phwb:typings-fix

Conversation

@phwb

@phwb phwb commented Jul 9, 2020

Copy link
Copy Markdown
Contributor

No description provided.

@phwb phwb mentioned this pull request Jul 9, 2020
@phwb

phwb commented Jul 9, 2020

Copy link
Copy Markdown
Contributor Author

@jmillan can you review PR?

@arkaev

arkaev commented Jul 9, 2020

Copy link
Copy Markdown

Wait. Why not devDependencies?

@phwb

phwb commented Jul 10, 2020

Copy link
Copy Markdown
Contributor Author

Wait. Why not devDependencies?

Because some types extends EventEmitter

@IlyaCherkasov

IlyaCherkasov commented Jun 17, 2022 •

Copy link
Copy Markdown

Would love this to be merged to fix typings imports

@jmillan
jmillan requested a review from ibc November 5, 2022 17:08
@ibc
ibc merged commit b7bf2f0 into versatica:master Nov 5, 2022
@jmillan

jmillan commented Nov 5, 2022

Copy link
Copy Markdown
Member

CHANGELOG was missing

@jmillan

jmillan commented Nov 5, 2022

Copy link
Copy Markdown
Member

CHANGELOG was missing

Updated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

5 participants