Repository navigation
Validate empty precompute results against the requested flag group - #592
Merged
luismeyer merged 1 commit intoNov 5, 2026
Conversation
Reject mismatches between a precompute code and the flags group passed to deserialize. The __no_flags__ sentinel is now only accepted for an empty group, and a signed code is no longer accepted for an empty group.
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
AndyBitz
approved these changes
Nov 5, 2026
luismeyer
deleted the
luismeyer/exp-3758-validate-empty-precompute-results-against-the-requested-flag
branch
November 5, 2026 11:22
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
deserializecurrently returns{}for the__no_flags__sentinel without checking whether the requested flags group is empty. That skips signature verification entirely: a non-empty group paired with'__no_flags__'silently resolves every flag toundefined, and callers fall back to their defaults.Changes
__no_flags__sentinel only when the flags group is empty.deserializepaths inprecompute.ts.Tests
packages/flags/src/next/precompute.test.tspackages/flags/src/sveltekit/precompute.test.tsFull suite: 156 tests passing.
type-checkandbiome checkclean.Notes
This changes how mismatched precompute codes behave. I'm opening it without public security wording; please coordinate classification and any public messaging with Security (EXP-3687).