Skip to content

Adopt the @upfluence/oss-components asset-map adapter - #288

Draft
phndiaye wants to merge 4 commits into
masterfrom
pn/asset-map-refactor
Draft

phndiaye wants to merge 4 commits into
masterfrom
pn/asset-map-refactor

Conversation

@phndiaye

@phndiaye phndiaye commented Oct 23, 2026 •

Copy link
Copy Markdown
Member

What does this PR do?

Part of VEL-8567: replace the build-time behavior of ember-cli-ifa with the owned OSS Components adapter ahead of the Vite migration. The shared asset-map service/helper keeps the existing runtime names; consumers explicitly opt into manifest injection through injectAssetMap (upfluence/oss-components#716).

In this repo:

  • Wraps 1 app/dummy/test build(s) with injectAssetMap, passing through fingerprint settings and rootURL, and writes assets/upfluence-asset-map.json.
  • Adds the matching upfluence:asset-map meta placeholder to 2 application/test HTML entry point(s).
  • Pins OSS Components to pn/asset-map-service-adapter (lockfile revision 9dcd77cf) and allows its Git-package build through pnpm onlyBuiltDependencies.
  • Adds the shared Font Awesome stylesheet (https://uweb.s3.us-east-1.amazonaws.com/fa-current/css/all.min.css) to the app/dummy page(s), ahead of the app stylesheet. It duplicates the Font Awesome that OSS Components still injects, and is groundwork for removing that injection.

Before merging: release OSS Components, replace the Git pin with its published version, and refresh the lockfile. The last two commits carry a [skip ci] marker (an empty one and the Font Awesome one). Strip the markers from the squash-merge message (or omit those commits when merging); otherwise post-merge deploy/release workflows can also be skipped. Run CI on the final release-pin update before merging.

Related to: VEL-8567

What are the observable changes?

🧑‍💻 Developer Heads Up

⚡ Since we are using Ember Octane now:

  • Feel free to migrate existing components to Glimmer Components.
  • Write new ones exclusively in it.

Useful Resource : Ember Octane vs Classic Cheat Sheet

Good PR checklist

  • Title makes sense
  • Is against the correct branch
  • Only addresses one issue
  • Properly assigned
  • Added/updated tests
  • Added/updated documentation
  • Migrated touched components to Glimmer Components
  • Properly labeled

Additional Notes

@linear-code

linear-code Bot commented Oct 23, 2026

Copy link
Copy Markdown

VEL-8567

Duplicates the Font Awesome that oss-components still injects; groundwork for removing that injection.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants