Repository navigation
Conversation
Duplicates the Font Awesome that oss-components still injects; groundwork for removing that injection.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Part of VEL-8567: replace the build-time behavior of
ember-cli-ifawith the owned OSS Components adapter ahead of the Vite migration. The sharedasset-mapservice/helper keeps the existing runtime names; consumers explicitly opt into manifest injection throughinjectAssetMap(upfluence/oss-components#716).In this repo:
injectAssetMap, passing through fingerprint settings androotURL, and writesassets/upfluence-asset-map.json.upfluence:asset-mapmeta placeholder to 2 application/test HTML entry point(s).pn/asset-map-service-adapter(lockfile revision9dcd77cf) and allows its Git-package build through pnpmonlyBuiltDependencies.https://uweb.s3.us-east-1.amazonaws.com/fa-current/css/all.min.css) to the app/dummy page(s), ahead of the app stylesheet. It duplicates the Font Awesome that OSS Components still injects, and is groundwork for removing that injection.Before merging: release OSS Components, replace the Git pin with its published version, and refresh the lockfile. The last two commits carry a
[skip ci]marker (an empty one and the Font Awesome one). Strip the markers from the squash-merge message (or omit those commits when merging); otherwise post-merge deploy/release workflows can also be skipped. Run CI on the final release-pin update before merging.Related to: VEL-8567
What are the observable changes?
🧑💻 Developer Heads Up
⚡ Since we are using Ember Octane now:
Useful Resource : Ember Octane vs Classic Cheat Sheet
Good PR checklist
Additional Notes