Skip to content

Add some basic shell scripts to automate some checks - #266

Open
will-langdale wants to merge 1 commit into
mainfrom
feat/check-scripts
Open

will-langdale wants to merge 1 commit into
mainfrom
feat/check-scripts

Conversation

@will-langdale

@will-langdale will-langdale commented Oct 1, 2026 •

Copy link
Copy Markdown

Description

Standalone Bash scripts measure the quick, GitHub API-backed parts of the code security checklist (see this discussion). The intention isn't to do this task with full unit testing, just to hammer out the low-hanging fruit as quickly as possible.

Artefact to build Script
Custom GitHub Action – checklist engine None
Reusable workflow wrapping the Action None
code-security-ci ruleset None
code_security_enrolled GitHub custom property check-code-security-enrolled.sh
Maintainer attestation register None
Maintainer compliance check None
Security configuration check check-security-configuration.sh
Datadog PR gates repository ruleset check check-datadog-pr-gates.sh
scs_portfolio check check-scs-portfolio.sh
PR template check check-pr-template.sh
SECURITY.md check check-no-security-md.sh
CODEOWNERS check check-codeowners.sh
Team membership check check-team-membership-review.sh
BIST Code Security Checklist template (code_security_checklist.md) None

Contributors

Just me and AI.

Type of change

  • Refactoring (made code better without changing its behaviour)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

How this has been tested

Run locally and confirmed they work as well as I can.

will.langdale@U-3TYMIBXECGY55 ~/D/github-standards (feat/check-scripts) [128]> find -name 'check-*.sh' -exec '{}' uktrade/matchlab ';'
FAIL [uktrade/matchlab] code_security_enrolled must be "true"; observed null. No legacy-property fallback.
PASS [uktrade/matchlab] .github/CODEOWNERS has no GitHub diagnostics and names @uktrade/data-matching-service as its valid primary team.
FAIL [uktrade/data-matching-service] Expected one [MEMBERSHIP_REVIEW=YYYY-MM-DD] marker.
PASS [uktrade/matchlab] No SECURITY.md path exists on main.
PASS [uktrade/matchlab] scs_portfolio is populated: Data and AI Services.
PASS [uktrade/matchlab] Datadog PR Gates is present and active; individual gates and branch coverage are not validated.
PASS [uktrade/matchlab] All repository-local PR templates contain "no secret values are present".
ERROR [uktrade/matchlab] Set EXPECTED_SECURITY_CONFIGURATION_ID to the approved positive numeric configuration ID.

Checklist

  • I have performed a self-review of my code
  • I have commented my code in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings

Reviewer Checklist

  • I have reviewed the PR and ensured no secret or sensitive values are present

@will-langdale
will-langdale requested a review from a team as a code owner October 1, 2026 10:58
@github-actions

github-actions Bot commented Oct 1, 2026

Copy link
Copy Markdown

Dependency Review

✅ No vulnerabilities or OpenSSF Scorecard issues found.

Scanned Files

None

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant