Skip to content
This repository was archived by the owner on Jan 5, 2024. It is now read-only.
This repository was archived by the owner on Jan 5, 2024. It is now read-only.

Get rid of getattr in modules generated with thrift.load. #306

Open

Description

@abhinav

This should be fairly trivial. We already iterate through all services and setattr them on the generated module. The same could be done for types, includes, and constants.

Worth noting that these attributes were renamed from foo to __foo__ in 1.0 and __includes__ is new in 1.0. So the code will have to use some hasattrs when doing this.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions