Skip to content
This repository was archived by the owner on Jan 5, 2024. It is now read-only.
This repository was archived by the owner on Jan 5, 2024. It is now read-only.

Include exception message in UnexpectedError error frame #269

Open

Description

@prashantv

Right now, the error frame description does not include any information about what failed:
https://github.com/uber/tchannel-python/blob/master/tchannel/tornado/dispatch.py#L231

We should consider adding e.message to the error frame for more information

cc @jcorbin

Activity

  1. jc-fireball commented on Oct 23, 2015

    @jc-fireball
    Contributor

    Hard to tell whether want to pass the stack trace into the error message and send back to client. On one hand the exception message may disclosure some internal information from server which the server owner may not want to share it with all clients (like http internal server error). On the other hand by giving more error information, client can know more about what's happening.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions