You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
ThriftSerializer.encodeBody() swallows important exceptions #150
Hi,
I just came to notice that the current implementation of the ThriftSerializer.encodeBody() will swallow any exceptions thrown by the validation of the thrift response and only print the exception stack trace:
I'd rather prefer to have these exceptions handled by the callee, if problem with serialization awareness is needed by the lib clients, however i'm not sure if this behaviour is somehow implied by how tchannel should function
p.s. by doing this, the actual tchannel calls would not get answered, since the responses will not get published. This will result in timeouts on the tchannel callers side
The code now logs the exception (instead of printing the stack trace to stdout).
Changing it to throw it instead does make sense yet might be a breaking change.
Activity
yborovikov commentedon Nov 22, 2017
The code now logs the exception (instead of printing the stack trace to stdout).
Changing it to throw it instead does make sense yet might be a breaking change.