Skip to content

Make Raw{Request,Response} ByteBufHolders #15

Open

Description

@willsalz

We get some nice benefits e.g. automatic object releasing by ChannelHandlers ( which can bite you if you don't know it's happening! ), and a nicer API for releasing payloads e.g. RawRequest.release() instead of RawRequest.getArg1().release(); RawRequest.getArg2().release(); RawRequest.getArg2().release().

I had this implemented by wrapping the 3 contained ByteBufs in a CompositeByteBuf, but I wasn't sure about the retain/release semantics of CompositeBuffers vs. raw ByteBufs so I took out the logic. This isn't a perf. win, but may simplify retain/release APIs down the road.

Activity

  1. added this to the v1 milestone on Aug 4, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

      Milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions