Skip to content

fix(change): reject non-canonical PR numbers in github ParseChangeID #773

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
behinddwalls merged 1 commit into from
Oct 5, 2026
Merged

fix(change): reject non-canonical PR numbers in github ParseChangeID #773

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions platform/base/change/github/change_id.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,15 +109,26 @@ func ParseChangeID(raw string) (ChangeID, error) {
}

prNumber, err := strconv.Atoi(prStr)

if err != nil {
return ChangeID{}, fmt.Errorf("invalid change ID %q: PR number %q is not a valid integer (expected format: %s)", raw, prStr, changeIDFormat)
}

if prNumber < 1 || strconv.Itoa(prNumber) != prStr {
return ChangeID{}, fmt.Errorf("invalid change ID %q: PR number %q must be a positive integer without sign or leading zeros (expected format: %s)", raw, prStr, changeIDFormat)
}

// Split repo path: last segment is repo name, everything before is the owner.
if len(repoSegments) < 2 {
return ChangeID{}, fmt.Errorf("invalid change ID %q: repo path must have at least owner/repo (expected format: %s)", raw, changeIDFormat)
}

for _, seg := range repoSegments {
if seg == "" {
return ChangeID{}, fmt.Errorf("invalid change ID %q: repo path contains an empty segment (expected format: %s)", raw, changeIDFormat)
}
}

repo := repoSegments[len(repoSegments)-1]
org := strings.Join(repoSegments[:len(repoSegments)-1], "/")

Expand Down
25 changes: 25 additions & 0 deletions platform/base/change/github/change_id_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -133,6 +133,31 @@ func TestParseChangeID(t *testing.T) {
raw: "github://github.example.com/uber/submitqueue/pull/abc/" + shaAFull,
wantErr: true,
},
{
name: "zero PR number",
raw: "github://github.example.com/uber/submitqueue/pull/0/" + shaAFull,
wantErr: true,
},
{
name: "negative PR number",
raw: "github://github.example.com/uber/submitqueue/pull/-3/" + shaAFull,
wantErr: true,
},
{
name: "plus-signed PR number",
raw: "github://github.example.com/uber/submitqueue/pull/+5/" + shaAFull,
wantErr: true,
},
{
name: "leading-zero PR number",
raw: "github://github.example.com/uber/submitqueue/pull/007/" + shaAFull,
wantErr: true,
},
{
name: "empty interior org segment",
raw: "github://github.example.com/uber//frontend/webapp/pull/42/" + shaAFull,
wantErr: true,
},
{
name: "empty SHA",
raw: "github://github.example.com/uber/submitqueue/pull/123/",
Expand Down
Loading