Repository navigation
Conversation
Contributor
|
Change looks good, thanks for contributing! I'm guessing sometime after Vertica 7.2 they changed the function arg from optional to required. If you haven't signed the CLA yet, please do, and I can get this pulled in. |
Author
|
Unfortunately I'm not able to sign the CLA. I will close this PR. |
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In Vertica,
CURRENT_TIMESTAMPis a function that accepts one argument, as per the docs. The docs provide this example query demonstrating its usage:Currently, queryparser fails to parse this query. This PR fixes this behaviour.
I've added this example to the tests, but I wasn't sure of where the best place to put it was. Please let me know if it is best placed somewhere else :)