Skip to content

Parse CURRENT_TIMESTAMP(1) in vertica - #54

Closed
asnr wants to merge 1 commit into
uber:masterfrom
asnr:fix-vertica-current-timestamp
Closed

asnr wants to merge 1 commit into
uber:masterfrom
asnr:fix-vertica-current-timestamp

Conversation

@asnr

@asnr asnr commented Jan 6, 2020

Copy link
Copy Markdown

In Vertica, CURRENT_TIMESTAMP is a function that accepts one argument, as per the docs. The docs provide this example query demonstrating its usage:

SELECT CURRENT_TIMESTAMP(1) AS time;

Currently, queryparser fails to parse this query. This PR fixes this behaviour.

I've added this example to the tests, but I wasn't sure of where the best place to put it was. Please let me know if it is best placed somewhere else :)

@h4v0kh3l1

Copy link
Copy Markdown
Contributor

Change looks good, thanks for contributing! I'm guessing sometime after Vertica 7.2 they changed the function arg from optional to required.

If you haven't signed the CLA yet, please do, and I can get this pulled in.

@asnr

asnr commented Jan 30, 2020

Copy link
Copy Markdown
Author

Unfortunately I'm not able to sign the CLA. I will close this PR.

@asnr asnr closed this Jan 30, 2020
@CLAassistant

Copy link
Copy Markdown

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants