Skip to content

fix(api-call): keep dot segments in keep-alive request paths - #68

Merged
tharropoulos merged 1 commit into
typesense:masterfrom
tharropoulos:fix/keep-alive-dot-segments
Nov 9, 2026
Merged

tharropoulos merged 1 commit into
typesense:masterfrom
tharropoulos:fix/keep-alive-dot-segments

Conversation

@tharropoulos

Copy link
Copy Markdown
Collaborator
  • pass the full URL to cached keep-alive connections, because Faraday merges a relative path into the base URL and drops . and .. segments
  • stop documents['..'].delete from sending DELETE /collections/c/ and dropping the whole collection when keep-alive is on (same for items['..'] on synonym and curation sets)
  • set the URL with req.url inside the request block, because passing an absolute URL to the verb makes Faraday read proxy env vars on every request
  • lower-case the node protocol in uri_for, because Faraday 2.9.2 and later treat HTTP://... as a relative path
  • add request-target specs for one-shot, keep-alive and an upper-case protocol, plus a real-server check that deleting document .. leaves the collection in place

@tharropoulos
tharropoulos merged commit 0e233cc into typesense:master Nov 9, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant