Repository navigation
refactor(configuration): use node[attr] in node_missing_parameters? - #65
Merged
tharropoulos merged 1 commit intoNov 11, 2026
Merged
Conversation
node is a Hash, so node.send(:[], attr) and node[attr] behave the same.
erimicel
force-pushed
the
simplify-node-missing-parameters
branch
from
November 10, 2026 20:19
8650529 to
f36636e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces
node.send(:[], attr)withnode[attr]inConfiguration#node_missing_parameters?.nodeis a Hash, so the behaviour is the same with less indirection. Split out from #60.Verification
bundle exec rspec spec/typesense/configuration_spec.rb: 5 examples, 0 failures. These include the missingprotocol/host/portcases.bundle exec rubocop lib/typesense/configuration.rb: no offenses.PR Checklist