0.4.4 fails to build with glibc 2.43 #159

Activity

1. tgurr commented on Feb 10, 2026

   

   tgurr

   on Feb 10, 2026

   Author

   More actions

   For anyone in need of a fix to apply downstream for the time being, Fedora ships with this patch: https://src.fedoraproject.org/rpms/patchutils/blob/rawhide/f/patchutils-0.4.4-ftbfs-gnulib.patch
2. twaugh commented on Feb 26, 2026

   

   twaugh

   on Feb 26, 2026

   Owner

   More actions

   Fixed in 0.4.5.

   ❤️React with ❤️1Reacted by Holger Hoffstätte
3. twaugh

   closed this as completedon Feb 26, 2026
4. hhoffstaette commented on Feb 26, 2026

   

   hhoffstaette

   on Feb 26, 2026

   Last edited by hhoffstaette

   Contributor

   More actions

   Well actually.. :-)

   clang -DHAVE_CONFIG_H -I.   -D_GNU_SOURCE -D_FORTIFY_SOURCE=2 -I./src -I./lib -I./lib -g -O2 -Wall -MT src/util.o -MD -MP -MF $depbase.Tpo -c -o src/util.o src/util.c &&\
   mv -f $depbase.Tpo $depbase.Po
   src/util.c:261:4: warning: assigning to 'char *' from 'const char *' discards qualifiers [-Wincompatible-pointer-types-discards-qualifiers]
     261 |         p = strrchr(name, '.');
         |           ^ ~~~~~~~~~~~~~~~~~~
   1 warning generated.
   depbase=`echo src/diff.o | sed 's|[^/]*$|.deps/&|;s|\.o$||'`;\
   clang -DHAVE_CONFIG_H -I.   -D_GNU_SOURCE -D_FORTIFY_SOURCE=2 -I./src -I./lib -I./lib -g -O2 -Wall -MT src/diff.o -MD -MP -MF $depbase.Tpo -c -o src/diff.o src/diff.c &&\
   mv -f $depbase.Tpo $depbase.Po
   src/diff.c:162:15: warning: initializing 'char *' with an expression of type 'const char *' discards qualifiers
         [-Wincompatible-pointer-types-discards-qualifiers]
     162 |         char *p = strchr (atatline, which);
         |               ^   ~~~~~~~~~~~~~~~~~~~~~~~~
   src/diff.c:193:5: warning: assigning to 'char *' from 'const char *' discards qualifiers [-Wincompatible-pointer-types-discards-qualifiers]
     193 |                 p = strchr (atatline, '-');
         |                   ^ ~~~~~~~~~~~~~~~~~~~~~~
   src/diff.c:207:5: warning: assigning to 'char *' from 'const char *' discards qualifiers [-Wincompatible-pointer-types-discards-qualifiers]
     207 |                 p = strchr (atatline, '+');
         |                   ^ ~~~~~~~~~~~~~~~~~~~~~~
   3 warnings generated.
   clang -I./src -I./lib -I./lib -g -O2 -Wall   -o src/interdiff src/interdiff.o src/util.o src/diff.o lib/libgnu.a  -lpcre2-posix
   depbase=`echo src/filterdiff.o | sed 's|[^/]*$|.deps/&|;s|\.o$||'`;\
   clang -DHAVE_CONFIG_H -I.   -D_GNU_SOURCE -D_FORTIFY_SOURCE=2 -I./src -I./lib -I./lib -g -O2 -Wall -MT src/filterdiff.o -MD -MP -MF $depbase.Tpo -c -o src/filterdiff.o src/filterdiff.c &&\
   mv -f $depbase.Tpo $depbase.Po
   clang -I./src -I./lib -I./lib -g -O2 -Wall   -o src/filterdiff src/filterdiff.o src/util.o src/diff.o lib/libgnu.a  -lpcre2-posix
   depbase=`echo src/rediff.o | sed 's|[^/]*$|.deps/&|;s|\.o$||'`;\
   clang -DHAVE_CONFIG_H -I.   -D_GNU_SOURCE -D_FORTIFY_SOURCE=2 -I./src -I./lib -I./lib -g -O2 -Wall -MT src/rediff.o -MD -MP -MF $depbase.Tpo -c -o src/rediff.o src/rediff.c &&\
   mv -f $depbase.Tpo $depbase.Po
   src/rediff.c:274:8: warning: initializing 'char *' with an expression of type 'const char *' discards qualifiers
         [-Wincompatible-pointer-types-discards-qualifiers]
     274 |         char *p = strchr (meta, '-'), *q;
         |               ^   ~~~~~~~~~~~~~~~~~~
   1 warning generated.
   

   diff.c and util.c can be fixed by simply marking p as const char *. rediff.c is a bit more tricky since meta is being passed in as const char * already and casting it to char * should be considered a Bad Idea. Maybe make meta mutable or operate on a copy.
5. hhoffstaette

   added 2 commits that reference this issue on Feb 26, 2026

   More const fixes for C23

   ...

   b24a87b

   More const fixes for C23 [0.4.x]

   ...

   0cfe623