Skip to content

excessive memory leaking #11

Open
Open

Description

@seiyria

over time, if used for a really long time (8-36 hours) this causes a webpage to become incredibly slow. tested with and without on a project and the speed does not drop if hacktimer is not included.

Activity

  1. turuslan commented on Nov 21, 2015

    @turuslan
    Owner

    thank you for reporting.
    i will try to find out and fix it.

  2. self-assigned this
    on Nov 24, 2015
  3. timotheeg commented on Nov 26, 2015

    @timotheeg

    FYI: I reckon it's because the callback map is not cleared on successful setTimeout callback. For setTimeouts, the callback map should be cleared even if clearTimeout is not called explicitly.

  4. added a commit that references this issue on Dec 3, 2015
  5. turuslan commented on Dec 3, 2015

    @turuslan
    Owner

    Thanks to @timotheeg, there was such a mistake of not deleting unused timeout entries. Commit e11f3ed must fix it.

  6. seiyria commented on Dec 3, 2015

    @seiyria
    Author

    I'll give this a try sometime later and see if it's still causing problems. If so, I'll let you know. Thanks!

  7. turuslan commented on Jan 18, 2016

    @turuslan
    Owner

    In commit e11f3ed I forgot to update silent version (HackTimer.silent.min.js) (issue 13) that you used (package.json).
    So it was not fixed that time.
    Now it is updated (8e2fef9, c06bbc6).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

No labels
No labels

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions