Repository navigation
Send AI temperature only to models that accept it - #477
Open
mainalisandeep062 wants to merge 1 commit into
Open
mainalisandeep062 wants to merge 1 commit into
mainalisandeep062 wants to merge 1 commit into
Conversation
Anthropic's Claude 5 models reject the temperature parameter with "`temperature` is deprecated for this model". All four agents set one with #[Temperature], so with AI_TEXT_PROVIDER=anthropic and a Claude 5 model every AI feature fails and the composer only shows "Could not generate a suggestion". OmitsUnsupportedTemperature replaces the attribute: each agent keeps its value and sends it unless the active text model is listed in trypost.ai.models_without_temperature (the Claude 5 family by default). The attribute has to go because laravel/ai falls back to it when temperature() returns null.
There was a problem hiding this comment.
Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota. Try requesting a review at a lower effort level.
An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #476.
Why
Anthropic's Claude 5 models reject the
temperatureparameter ("temperatureis deprecated for this model"). All four agents set one with#[Temperature], so with a Claude 5 model every AI feature fails and the composer only shows "Could not generate a suggestion". Details and the API response are in #476.What
App\Ai\Concerns\OmitsUnsupportedTemperaturereplaces the#[Temperature]attribute. Each agent keeps its value (IdeaGenerator0.8,PostWritingAssistant0.7,PostContentShortenerandMediaAltTextGenerator0.2) inpreferredTemperature()and sends it unless the active text model rejects temperatures.TextGenerationOptions::resolve()falls back to the attribute whentemperature()returns null.config('trypost.ai.models_without_temperature'). The default only matches the Claude 5 family (claude-sonnet-5-5,claude-opus-5-5-20261001, ...), so Claude 4.x (claude-sonnet-4-5, dated or not) and other providers keep sending their temperature.Tests
tests/Unit/Ai/Agents/TemperatureTest.php, over every agent inapp/Ai/AgentslikeAgentProviderResolutionTest:#[Temperature]attribute;TextGenerationOptions::forAgent()carries the agent's temperature forclaude-sonnet-4-5and none forclaude-sonnet-5-5.