Repository navigation
🐛 fix(tk): avoid display access during probing - #211
Merged
gaborbernat merged 2 commits intoNov 3, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
_resolve_tk_lib()loaded Tk to obtain its version during interpreter discovery. WithTCL_LIBRARYset, an unresponsive X display could block the caller outside the probe timeout. Discovery now obtains the linked Tk version without loading the GUI. This addresses draft advisory ANT-2026-0JRI1J0P.Tk library resolution
The old
package require Tkcall loaded Tk while the collector was locating library files. Tk opens the display when it creates a main window, and the screen name can come fromDISPLAY. CPython exposes the linked Tk version as_tkinter.TK_VERSION. The collector now uses that constant to find the library directory without opening a display.Behavior changes
Tcl/Tk metadata collection no longer loads Tk or opens a display. It can locate the Tk library on headless systems where loading Tk raised a display error. The
TCL_LIBRARYgate remains in place.Reported by Antigravity: ANT-2026-0JRI1J0P.